Re: [PATCH v2 1/2] msvcrt/tests: Add tests for _creat.

[Piotr Caban]

Hi,

please fix the implementation in first patch and then add test in 
second. Currently the tests are using garbage data from stack causing 
random failures:
file.c:2419: Test failed: expected read-only file
file.c:2441: Test succeeded inside todo block: expected rw file

Thanks,
Piotr

[PATCH v2 1/2] msvcrt/tests: Add tests for _creat.

[Lauri Kenttä]

On 2017-02-07 11:53, Piotr Caban wrote:
> Hi,
>
> please fix the implementation in first patch and then add test in
> second. Currently the tests are using garbage data from stack causing
> random failures:
> file.c:2419: Test failed: expected read-only file
> file.c:2441: Test succeeded inside todo block: expected rw file

Somehow I was lucky enough to run this around 30 times successfully.
But you're right, I'll have to resend in reverse order.
(For the record, the garbage is in the broken _creat, not my test.)

-- 
Lauri Kenttä