Re: mshtml: Implement IHTMLStyle_put_backgroundColor

hi alistair,
you say it implements the put method but the patch has only the get 
method... typo?

regards,
ricardo

--------------------------------------------------
From: "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com>
Sent: Wednesday, February 04, 2009 5:02 AM
To: <wine-patches(a)winehq.org>
Subject: mshtml: Implement IHTMLStyle_put_backgroundColor
> Hi,
>
> Changelog:
> mshtml: Implement IHTMLStyle_put_backgroundColor
>
> Best Regards
>  Alistair Leslie-Hughes

> From fde0238571c3eca78527600d846ff88add6510b0 Mon Sep 17 00:00:00 2001
> From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
> Date: Wed, 4 Feb 2009 16:01:05 +1100
> Subject: [PATCH] Implement IHTMLStyle_put_backgroundColor
> To: wine-patches <wine-patches(a)winehq.org>
>
> ---
> dlls/mshtml/htmlstyle.c |    6 ++++--
> dlls/mshtml/tests/dom.c |    6 ++++++
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c
> index ad9d095..4964c10 100644
> --- a/dlls/mshtml/htmlstyle.c
> +++ b/dlls/mshtml/htmlstyle.c
> @@ -743,8 +743,10 @@ static HRESULT WINAPI 
> HTMLStyle_put_backgroundColor(IHTMLStyle *iface, VARIANT v
> static HRESULT WINAPI HTMLStyle_get_backgroundColor(IHTMLStyle *iface, 
> VARIANT *p)
> {
>     HTMLStyle *This = HTMLSTYLE_THIS(iface);
> -    FIXME("(%p)->(%p)\n", This, p);
> -    return E_NOTIMPL;
> +    TRACE("(%p)->(%p)\n", This, p);
> +
> +    V_VT(p) = VT_BSTR;
> +    return get_style_attr(This, STYLEID_BACKGROUND_COLOR, &V_BSTR(p));
> }
>
> static HRESULT WINAPI HTMLStyle_put_backgroundImage(IHTMLStyle *iface, 
> BSTR v)
> diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c
> index 62a07bc..77075fb 100644
> --- a/dlls/mshtml/tests/dom.c
> +++ b/dlls/mshtml/tests/dom.c
> @@ -2906,6 +2906,12 @@ static void test_default_style(IHTMLStyle *style)
>     test_border_styles(style, str);
>     SysFreeString(str);
>
> +    hres = IHTMLStyle_get_backgroundColor(style, &v);
> +    ok(hres == S_OK, "get_backgroundColor: %08x\n", hres);
> +    ok(V_VT(&v) == VT_BSTR, "type failed: %d\n", V_VT(&v));
> +    ok(!V_BSTR(&v), "str=%s\n", dbgstr_w(V_BSTR(&v)));
> +    VariantClear(&v);
> +
>     hres = IHTMLStyle_QueryInterface(style, &IID_IHTMLStyle2, 
> (void**)&style2);
>     ok(hres == S_OK, "Could not get IHTMLStyle2 iface: %08x\n", hres);
>     if(SUCCEEDED(hres)) {
> -- 
> 1.5.4.3

>