Re: Patch for a bug in server/select.c

[Morten Welinder]

> +#ifdef __NetBSD__
> +	  if (pollfd[i].revents & !(pollfd[i].revents & POLLNVAL))
> +#else	     
>         if (pollfd[i].revents)
> +#endif

I would hate to see this kind of __NetBSD__ pollution of Wine.
(I believe something like it slipped through recently -- not
good.)

It used to be that documentation/porting contained lots of reasons
why mentioning any OS name in places like this is a bad idea.

I suggest a suitable configure test or a porting wrapper for poll.

Morten

Patch for a bug in server/select.c

[Bang Jun-Young]

On Fri, May 18, 2001 at 06:42:59PM -0000, Morten Welinder wrote:
> > +#ifdef __NetBSD__
> > +	  if (pollfd[i].revents & !(pollfd[i].revents & POLLNVAL))
> > +#else	     
> >         if (pollfd[i].revents)
> > +#endif
>
> I would hate to see this kind of __NetBSD__ pollution of Wine.
> (I believe something like it slipped through recently -- not
> good.)
>
> It used to be that documentation/porting contained lots of reasons
> why mentioning any OS name in places like this is a bad idea.
>
> I suggest a suitable configure test or a porting wrapper for poll.

I believe stripping __NetBSD__ #if/endif pair doesn't any harm in any 
cases, but just a little bit of performance degradation. Which one
should we choose between readability, portability, or performance? 

Jun-Young
 
-- 
Bang Jun-Young <bjy(a)mogua.org>