Where's msrle.avi? (was: winmm: Add the tests for mmioOpen and mmioSetBuffer, make them pass under Wine)
In http://www.winehq.org/pipermail/wine-patches/2008-June/056002.html Dmitry enabled a test that is skipped unless file msrle.avi is present. Where is that file? Why isn't it in git?
"Dan Kegel" <dank(a)kegel.com> wrote:
In http://www.winehq.org/pipermail/wine-patches/2008-June/056002.html Dmitry enabled a test that is skipped unless file msrle.avi is present. Where is that file? Why isn't it in git?
That's an optional file that could be dropped in into the tests directory so that the test parses some real AVI file along with the (synthesized) data existing in the test. That could be an AVI from any source, there is no particular requirements. The only purpose of referencing msrle.avi is to (optionally) extend the test coverage. -- Dmitry.
On Sun, Oct 26, 2008 at 8:48 PM, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote:
Dmitry enabled a test that is skipped unless file msrle.avi is present.
That's an optional file that could be dropped in into the tests directory so that the test parses some real AVI file along with the (synthesized) data existing in the test. That could be an AVI from any source, there is no particular requirements. The only purpose of referencing msrle.avi is to (optionally) extend the test coverage.
OK... any reason we don't check in a real .avi into git? - Dan
"Dan Kegel" <dank(a)kegel.com> wrote:
That's an optional file that could be dropped in into the tests directory so that the test parses some real AVI file along with the (synthesized) data existing in the test. That could be an AVI from any source, there is no particular requirements. The only purpose of referencing msrle.avi is to (optionally) extend the test coverage.
OK... any reason we don't check in a real .avi into git?
The test already has the data resembling an AVI file, and checking in a real AVI into git would actually reduce the coverage IMO, not extend it (anyone interested should be able to drop its own AVI). And 'optional' really means optional. -- Dmitry.
participants (2)
-
Dan Kegel -
Dmitry Timoshkov