[PATCH v3 2/4] d3dx10: Implement D3DX10GetImageInfoFromFileW().

[Ziqing Hui]

Signed-off-by: Ziqing Hui <zhui(a)codeweavers.com>
---

v3: Use ReadFile rather than mapping file.

 dlls/d3dx10_43/tests/d3dx10.c |  4 +-
 dlls/d3dx10_43/texture.c      | 78 ++++++++++++++++++++++++++++++++++-
 2 files changed, 77 insertions(+), 5 deletions(-)

[Matteo Bruni]

On Fri, Sep 25, 2020 at 5:12 AM Ziqing Hui <zhui(a)codeweavers.com> wrote:
>

The patch is okay but I wonder what's that free_file_buffer() about:
are you planning to extend it later on? Otherwise it seems better to
just call heap_free() right away, I think.

Just let me know, I can sign-off with or without that part amended, no
need to resend.

[Ziqing Hui]

I'm agree that that it's better to call heap_free().

On 9/29/20 4:30 PM, Matteo Bruni wrote:
> On Fri, Sep 25, 2020 at 5:12 AM Ziqing Hui <zhui(a)codeweavers.com> wrote:
> The patch is okay but I wonder what's that free_file_buffer() about:
> are you planning to extend it later on? Otherwise it seems better to
> just call heap_free() right away, I think.
>
> Just let me know, I can sign-off with or without that part amended, no
> need to resend.