Re: [PATCH 4/4] vbscript: Implemented ScriptEngineMinorVersion(try 2)

[Jacek Caban]

Hi Shuai,

On 28/07/14 04:49, Shuai Meng wrote:
> static HRESULT Global_ScriptEngineMinorVersion(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res)
>   {
> -    FIXME("\n");
> -    return E_NOTIMPL;
> +    int minorversion = 8;

Please use something like VBSCRIPT_MINOR_VERSION in a header file instead of hardcoding it here. This will allow sharing the value with resources strings in the future.

Jacek