Re: [PATCH 1/4] xinput1_3: Better trace all functions

[Sebastian Lackner]

On 31.08.2016 20:17, Bruno Jesus wrote:
> -    FIXME("(%d %p %p) Stub!\n", dwUserIndex, pDSoundRenderGuid, pDSoundCaptureGuid);
> +    FIXME("(index %u, render guid %p, capture guid %p) Stub!\n", index, render_guid, capture_guid);

debugstr_guid() would be more appropriate for tracing GUIDs.

[PATCH 1/4] xinput1_3: Better trace all functions

[Bruno Jesus]

On Wed, Aug 31, 2016 at 3:23 PM, Sebastian Lackner
<sebastian(a)fds-team.de> wrote:
> On 31.08.2016 20:17, Bruno Jesus wrote:
> > -    FIXME("(%d %p %p) Stub!\n", dwUserIndex, pDSoundRenderGuid, pDSoundCaptureGuid);
> > +    FIXME("(index %u, render guid %p, capture guid %p) Stub!\n", index, render_guid, capture_guid);
>
> debugstr_guid() would be more appropriate for tracing GUIDs.

They are output parameters ;-)

[PATCH 1/4] xinput1_3: Better trace all functions

[Sebastian Lackner]

On 31.08.2016 20:30, Bruno Jesus wrote:
> On Wed, Aug 31, 2016 at 3:23 PM, Sebastian Lackner
> <sebastian(a)fds-team.de> wrote:
> > On 31.08.2016 20:17, Bruno Jesus wrote:
> > > -    FIXME("(%d %p %p) Stub!\n", dwUserIndex, pDSoundRenderGuid, pDSoundCaptureGuid);
> > > +    FIXME("(index %u, render guid %p, capture guid %p) Stub!\n", index, render_guid, capture_guid);
> >
> > debugstr_guid() would be more appropriate for tracing GUIDs.
>
> They are output parameters ;-)

Oops, you are right. ;)