[Request for review] wrc: Add support for nameID with quotes

[Tijnema]

Hello all,

I was just checking around some old bugs and found 786 still opened. I've
written a patch for it, but I want to know if I'm anywhere close to get it
in.

I'm sorry if I'm only wasting your time.

Matijn

[Alexandre Julliard]

Tijnema <tijnema(a)gmail.com> writes:
> Hello all,
>
> I was just checking around some old bugs and found 786 still opened. I've
> written a patch for it, but I want to know if I'm anywhere close to get it
> in.

That would be a good way to handle quoted strings, but that's not what
Windows does. It doesn't really handle them, the quotes are simply
copied through. You can probably even put quotes in the middle of the
name. The behavior of the RC parser can be quite mysterious at times.

-- 
Alexandre Julliard
julliard(a)winehq.org

[Matijn Woudt]

On Wed, Jun 3, 2009 at 9:28 AM, Alexandre Julliard <julliard(a)winehq.org> wrote:
> Tijnema <tijnema(a)gmail.com> writes:
> > Hello all,
> >
> > I was just checking around some old bugs and found 786 still opened. I've
> > written a patch for it, but I want to know if I'm anywhere close to get it
> > in.
>
> That would be a good way to handle quoted strings, but that's not what
> Windows does. It doesn't really handle them, the quotes are simply
> copied through. You can probably even put quotes in the middle of the
> name. The behavior of the RC parser can be quite mysterious at times.

Thanks, didn't notice that one. I've checked it with the rc from
visual studio 2008 and you're right, it's really mysterious(just like
the rest of windows). Single and double quotes are just copied, but
only if they are in pairs. Though, there can be a single quote within
two double quotes, and the other way around.

I've attached a patch for this behaviour, is it ready to send to wine-patches?

Matijn Woudt

[Alexandre Julliard]

Matijn Woudt <tijnema(a)gmail.com> writes:
> Thanks, didn't notice that one. I've checked it with the rc from
> visual studio 2008 and you're right, it's really mysterious(just like
> the rest of windows). Single and double quotes are just copied, but
> only if they are in pairs. Though, there can be a single quote within
> two double quotes, and the other way around.
>
> I've attached a patch for this behaviour, is it ready to send to wine-patches?

I expect it will break parsing of normal strings.

-- 
Alexandre Julliard
julliard(a)winehq.org

[James McKenzie]

Alexandre Julliard wrote:
> Matijn Woudt <tijnema(a)gmail.com> writes:
> > Thanks, didn't notice that one. I've checked it with the rc from
> > visual studio 2008 and you're right, it's really mysterious(just like
> > the rest of windows). Single and double quotes are just copied, but
> > only if they are in pairs. Though, there can be a single quote within
> > two double quotes, and the other way around.
> >
> > I've attached a patch for this behaviour, is it ready to send to wine-patches?
>
> I expect it will break parsing of normal strings.

As you state (AJ):  A test case would be great to show what Windows(TM)
and what Wine does to see if the patch really fixes the problem.

James McKenzie

[Dmitry Timoshkov]

"James McKenzie" <jjmckenzie51(a)earthlink.net> wrote:
> As you state (AJ):  A test case would be great to show what Windows(TM)
> and what Wine does to see if the patch really fixes the problem.

Windows(TM) does nothing with resource files.

-- 
Dmitry.