Re: user32: Add a test for reparenting a WS_POPUP window to a WS_CHILD parent. Take 2.

[Alexandre Julliard]

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes:
> This test is supposed to show the root of the problem with the test
> application attached to the bug 13951. It appears that the check performed
> by server/window.c,is_top_level_window() is not correct (which leads to
> a SetWindowPos() failure to set foreground window), and probably should be
> replaced by simple (win->style & (WS_CHILD | WS_POPUP)) != WS_CHILD.

Maybe, but the test doesn't really demonstrate that.

-- 
Alexandre Julliard
julliard(a)winehq.org

user32: Add a test for reparenting a WS_POPUP window to a WS_CHILD parent. Take 2.

[Dmitry Timoshkov]

Alexandre Julliard <julliard(a)winehq.org> wrote:
> > This test is supposed to show the root of the problem with the test
> > application attached to the bug 13951. It appears that the check performed
> > by server/window.c,is_top_level_window() is not correct (which leads to
> > a SetWindowPos() failure to set foreground window), and probably should be
> > replaced by simple (win->style & (WS_CHILD | WS_POPUP)) != WS_CHILD.
>
> Maybe, but the test doesn't really demonstrate that.

That was just a guess, I hope that doesn't invalidate the test. If there is
a need for additional tests please let me know and I'll add them later.

-- 
Dmitry.