[PATCH 6/6] riched20: Only invalidate the selection if it's not hidden.
Signed-off-by: Huw Davies <huw(a)codeweavers.com> --- dlls/riched20/editor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c index 118c64652e..b10f719bb0 100644 --- a/dlls/riched20/editor.c +++ b/dlls/riched20/editor.c @@ -2153,9 +2153,9 @@ int set_selection( ME_TextEditor *editor, int to, int from ) TRACE("%d - %d\n", to, from ); - ME_InvalidateSelection( editor ); + if (!editor->bHideSelection) ME_InvalidateSelection( editor ); end = set_selection_cursors( editor, to, from ); - ME_InvalidateSelection( editor ); + if (!editor->bHideSelection) ME_InvalidateSelection( editor ); update_caret( editor ); ME_SendSelChange( editor ); -- 2.18.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=55515 Your paranoid android. === debian10 (32 bit report) === riched20: editor.c:6624: Test failed: wrong event mask (0x0) during WM_COMMAND === debian10 (32 bit Chinese:China report) === riched20: editor.c:6624: Test failed: wrong event mask (0x0) during WM_COMMAND === debian10 (32 bit WoW report) === riched20: editor.c:6624: Test failed: wrong event mask (0x0) during WM_COMMAND === debian10 (64 bit WoW report) === riched20: editor.c:6624: Test failed: wrong event mask (0x0) during WM_COMMAND
participants (2)
-
Huw Davies -
Marvin