[PATCH] dbghelp: Return NULL instead of IMAGE_NO_MAP when PE file mapping fails.
16 Jul
2019
16 Jul
'19
3:41 a.m.
A NULL test is always applied to the return value from pe_map_full(), but IMAGE_NO_MAP is not NULL, it is ((void*)-1). Signed-off-by: Conor McCarthy <cmccarthy(a)codeweavers.com> --- dlls/dbghelp/pe_module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/dbghelp/pe_module.c b/dlls/dbghelp/pe_module.c index 58530e73..4b7c7baa 100644 --- a/dlls/dbghelp/pe_module.c +++ b/dlls/dbghelp/pe_module.c @@ -53,7 +53,7 @@ static void* pe_map_full(struct image_file_map* fmap, IMAGE_NT_HEADERS** nth) fmap->u.pe.full_count++; return fmap->u.pe.full_map; } - return IMAGE_NO_MAP; + return NULL; } static void pe_unmap_full(struct image_file_map* fmap) -- 2.22.0
2344
Age (days ago)
2344
Last active (days ago)
0 comments
1 participants
participants (1)
-
Conor McCarthy