Re: dlls/gdi/dib.c GetDIBits

[Uwe Bonnes]

> > > > > "Ulrich" == Ulrich Czekalla <ulrich.czekalla(a)utoronto.ca> writes:

Ulrich> This patch fixes a regression that happened quite sometime
    Ulrich> ago. We don't always fill in the BITMAPINFO struct fields on the
    Ulrich> way out and this broke my app because it uses these values to
    Ulrich> allocate enough memory to hold the bits.

Ullrich,

I see a lot of indentation change and only 2 or 3 lines of real code
change. Can you perhaps resent with the real code change better visible? I
have a problem with CopyImage, maybe it is affected by the regression you
fix. Tagging the changes for debugging can help me to be sure about the
change.

Thanks

-- 
Uwe Bonnes                bon(a)elektron.ikp.physik.tu-darmstadt.de

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. [phone] -------- Fax. [phone] ----------

dlls/gdi/dib.c GetDIBits

[Ulrich Czekalla]

Uwe,

Here you go. I hope it helps.

/Ulrich

On Wed, Jun 01, 2005 at 10:05:08AM +0200, Uwe Bonnes wrote:
> > > > > > "Ulrich" == Ulrich Czekalla <ulrich.czekalla(a)utoronto.ca> writes:
>
> Ulrich> This patch fixes a regression that happened quite sometime
>     Ulrich> ago. We don't always fill in the BITMAPINFO struct fields on the
>     Ulrich> way out and this broke my app because it uses these values to
>     Ulrich> allocate enough memory to hold the bits.
>
> Ullrich,
>
> I see a lot of indentation change and only 2 or 3 lines of real code
> change. Can you perhaps resent with the real code change better visible? I
> have a problem with CopyImage, maybe it is affected by the regression you
> fix. Tagging the changes for debugging can help me to be sure about the
> change.
>
> Thanks
>
> -- 
> Uwe Bonnes                bon(a)elektron.ikp.physik.tu-darmstadt.de
>
> Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
> --------- Tel. [phone] -------- Fax. [phone] ----------

dlls/gdi/dib.c GetDIBits

[Uwe Bonnes]

> > > > > "Ulrich" == Ulrich Czekalla <ulrich.czekalla(a)utoronto.ca> writes:

Ulrich> Uwe, Here you go. I hope it helps.

Thanks,

AvrStudio doesn't take that code path however, neither with bpp==0 or else ...
-- 
Uwe Bonnes                bon(a)elektron.ikp.physik.tu-darmstadt.de

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. [phone] -------- Fax. [phone] ----------