Re: comctl: allow label edit only if treeview style allows editing

[Alexandre Julliard]

Daniel Jelinski <djelinski1(a)gmail.com> writes:
> From 21d26b76560f0c15a3d302883efa2d41d940a093 Mon Sep 17 00:00:00 2001
> From: Daniel Jelinski <djelinski1(a)gmail.com>
> Date: Sat, 2 Jun 2012 07:23:32 +0200
> Subject: comctl: allow label edit only if treeview style allows editing
>
> Native comctl behaves this way - noticed when debugging regedit

It breaks the tests:

../../../tools/runtest -q -P wine -M shell32.dll -T ../../.. -p shell32_test.exe.so brsfolder.c && touch brsfolder.ok
brsfolder.c:225: Test failed: The new folder did not get the name foo
brsfolder.c:232: Test failed: SHBrowseForFolder did not return the pidl for the new folder. Expected 'Z:\home\julliard\wine\wine\dlls\shell32\tests\test_click_make_new_folder_button\foo' got 'Z:\home\julliard\wine\wine\dlls\shell32\tests\test_click_make_new_folder_button\New Folder'
make: *** [brsfolder.ok] Error 2

-- 
Alexandre Julliard
julliard(a)winehq.org

comctl: allow label edit only if treeview style allows editing

[Daniel Jelinski]

2012/6/4 Alexandre Julliard <julliard(a)winehq.org>:
> Daniel Jelinski <djelinski1(a)gmail.com> writes:
> > From 21d26b76560f0c15a3d302883efa2d41d940a093 Mon Sep 17 00:00:00 2001
> > From: Daniel Jelinski <djelinski1(a)gmail.com>
> > Date: Sat, 2 Jun 2012 07:23:32 +0200
> > Subject: comctl: allow label edit only if treeview style allows editing
> >
> > Native comctl behaves this way - noticed when debugging regedit
>
> It breaks the tests:
>
> ../../../tools/runtest -q -P wine -M shell32.dll -T ../../.. -p shell32_test.exe.so brsfolder.c && touch brsfolder.ok
> brsfolder.c:225: Test failed: The new folder did not get the name foo
> brsfolder.c:232: Test failed: SHBrowseForFolder did not return the pidl for the new folder. Expected 'Z:\home\julliard\wine\wine\dlls\shell32\tests\test_click_make_new_folder_button\foo' got 'Z:\home\julliard\wine\wine\dlls\shell32\tests\test_click_make_new_folder_button\New Folder'
> make: *** [brsfolder.ok] Error 2

Ah, thank you for this information. I'll look into it. I stopped doing
make test on my machine some time ago, when I found out that some
tests do consistently fail on my machine (clean prefix or not), and
others consistently hang, thus preventing make test -k. I don't
install wine-gecko, maybe that's the reason.

-- 
Regards,
Daniel