[PATCH] d3dx9: Avoid double free on effect initialization failure.

[Matteo Bruni]

Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com>
---
 dlls/d3dx9_36/effect.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c
index 51c7a37575a..3a8e15217b6 100644
--- a/dlls/d3dx9_36/effect.c
+++ b/dlls/d3dx9_36/effect.c
@@ -6303,7 +6303,6 @@ static HRESULT d3dx9_base_effect_init(struct d3dx9_base_effect *base,
                             debugstr_a(skip_constants[i]), j);
                     HeapFree(GetProcessHeap(), 0, skip_constants_buffer);
                     HeapFree(GetProcessHeap(), 0, skip_constants);
-                    d3dx9_base_effect_cleanup(effect);
                     return D3DERR_INVALIDCALL;
                 }
             }
-- 
2.19.2

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=49542

Your paranoid android.


=== debian9 (build log) ===

error: patch failed: dlls/d3dx9_36/effect.c:6303
Task: Patch failed to apply

=== debian9b (build log) ===

error: patch failed: dlls/d3dx9_36/effect.c:6303
Task: Patch failed to apply