Re: winemac.drv: Improved App name on windows and menus (Mac Driver)
Hi, On Jun 10, 2015, at 9:48 AM, Vitor Marques <vitor251093(a)gmail.com> wrote:
In the actual code, the Mac Driver uses the Bundle Name on the Hide and Quit buttons, but not in the main menu item, which doesn't make sense since that's the most important place for the app name. It's a very simple change that surely will be very welcome to all Mac users. I've also attached the patch in case Gmail's line-wrapping cause any trouble. Although I have not tested, the changes are simple enough to be analyzed in sight. My system is a Mac OS X 10.10.
Thanks for your interest in the Mac driver and your attempt to improve it. Unfortunately, it's clear you haven't tested, since this won't run. You've misspelled "length" as "lenght", which would cause an unrecognized selector exception at run time if it even compiles. But, more importantly, the title that a program sets for the application menu is ignored by Cocoa. It uses the bundle name regardless. So, this change has no effect. Was there an actual problem behavior that you observed that you were trying to fix? Or was this just determined by reading the code? -Ken
The original MacDriver code used "Wine" as the application menu name. In that way, it doesn't matter if the user changes the Bundle Name, the app name will always be "Wine". After that change, the app name will be the Bundle Name, as it should be. That's a problem if you consider that the user might change the Wine.app Bundle Name in order to make the app look more native; since the original icon is already loaded by Wine, that would be "the last thing on the way". Since there is a typo, should I repair it, test it and then send it again? 2015-06-11 12:15 GMT-03:00 Ken Thomases <ken(a)codeweavers.com>:
Hi,
On Jun 10, 2015, at 9:48 AM, Vitor Marques <vitor251093(a)gmail.com> wrote:
In the actual code, the Mac Driver uses the Bundle Name on the Hide and Quit buttons, but not in the main menu item, which doesn't make sense since that's the most important place for the app name. It's a very simple change that surely will be very welcome to all Mac users. I've also attached the patch in case Gmail's line-wrapping cause any trouble. Although I have not tested, the changes are simple enough to be analyzed in sight. My system is a Mac OS X 10.10.
Thanks for your interest in the Mac driver and your attempt to improve it. Unfortunately, it's clear you haven't tested, since this won't run. You've misspelled "length" as "lenght", which would cause an unrecognized selector exception at run time if it even compiles.
But, more importantly, the title that a program sets for the application menu is ignored by Cocoa. It uses the bundle name regardless. So, this change has no effect.
Was there an actual problem behavior that you observed that you were trying to fix? Or was this just determined by reading the code?
-Ken
-- Vitor Marques de Miranda Desenvolvedor de Software e Graduando em Ciência da Computação pela UFRJ Contato telefônico: (21) 98723-4225
On Jun 11, 2015, at 10:21 AM, Vitor Marques <vitor251093(a)gmail.com> wrote:
The original MacDriver code used "Wine" as the application menu name. In that way, it doesn't matter if the user changes the Bundle Name, the app name will always be "Wine".
That's not true. As I said, Cocoa uses the bundle name regardless of what the code has assigned. Have you tried what you suggest (changing the bundle name)? If so, what exactly did you try?
After that change, the app name will be the Bundle Name, as it should be.
Before that change, it will be, too.
Since there is a typo, should I repair it, test it and then send it again?
You should test it and confirm for yourself that it has no effect. If there's still a problem, you can explain what is in detail. Then we can try to help you fix it. Regards, Ken
participants (2)
-
Ken Thomases -
Vitor Marques