Re: [PATCH 2/5] d3d10core: Implement d3d10_device_CopyResource().
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-08-04 12:17, schrieb Henri Verbeet:
+ if (dst_resource->type != WINED3D_RTYPE_TEXTURE) + { + FIXME("Not implemented for %s resources.\n", debug_d3dresourcetype(dst_resource->type)); + return; + } What's the point of implementing this based on textures and blits? It seems to me that a major restructuring will be needed to make this work on buffers.
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJT35GOAAoJEN0/YqbEcdMwljwQAI2wEkyQHnUbwVIc6wV1bkm6 25ySqo8ZC27L72eHHPpA6nBNDObcbN19MpnTGh57cK1xzt6aC/KBWwCotXkbgKzK almnHatukw7Nkms1jMGn7C0ROQRcdBC4VHKpeINKcCdTxfosm81NOpj9eofy0hB1 BGqWzAhS9oOKGmQZznIHeWJJNuRe5skvsOVvSg4bbaHGi1528BgKLLxRtlFfbXbO LNT3SnGvAI9jJC2lJEJ1SH62NkPXJmh8gIm5ptGS2JNzkT7EjNQyxqBJ1uTjlsAH jyIX1+XZx+H950ucH1RktOyccowPzi1TY2qe6nBDDr4G5u/mgfzXcGbHcUd1G51K DPP09g4NdaPExjfi40c0CgD0xRNgu7JInhzqLiBeEU2LBiXiSNC+wR8oXSlOroMj rC93/J2CqJ+7emZ1SQSq+zQECdaqscQ11iPPQGfKkwxlm8XwF+knMh99hnyknaQs wTbRh9Fp0OzM7cs81E3GL/KxJ+pmqctLBZSVAn6VHAXs06d3BQ+moX5D7sZaopQ/ y2U83wECb3DwSHp1ihbhoM6en9CWxdkLn+JqA8VRLiS803el7e7QvpmRzR7t8+VA O4jvo6v7TWszpsL2HbuyCJeOnWsVXAjIxlB2Eok8CI+FfYc0S20QCBMaFw1ixVIr BiyVPU9VwG/qicUSK53R =5T4j -----END PGP SIGNATURE-----
On 4 August 2014 15:58, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote:
Am 2014-08-04 12:17, schrieb Henri Verbeet:
+ if (dst_resource->type != WINED3D_RTYPE_TEXTURE) + { + FIXME("Not implemented for %s resources.\n", debug_d3dresourcetype(dst_resource->type)); + return; + } What's the point of implementing this based on textures and blits? It seems to me that a major restructuring will be needed to make this work on buffers.
Not that much, since all that's really needed is to generalize the blitter infrastructure to handle buffer resources. The main reason for implementing this now and not in e.g. a year though is that we'll need CopyResource() to read back the output of any test that does any kind of rendering.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-08-04 16:04, schrieb Henri Verbeet:
The main reason for implementing this now and not in e.g. a year though is that we'll need CopyResource() to read back the output of any test that does any kind of rendering. Ok. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJT35OwAAoJEN0/YqbEcdMwKygQAJgK42FjC7h9XY2FLXPV/eDS nF8lcUInLml16tNt2cTTfuSUYJ2waWGBCr1HUTBkFjKY92hagQmX+CmnCOlsN/32 94O4lTzkX0lEL7Yn3q3bVMy5QkaRK575Ps7W12v8ybhTEMZhwetkaT4F4J9xQa7+ V2JPFiKLv4ZWHaZfIKI7iNoARZgBn3SS6o7ipQzMyXR1xBmDJYDFtTSxnRLdIR3O CPngSeyLSnHRD4UQNUOh5wB8MPMrrh13TxIokNZ/r2Eb/lT1IzEnReFd7W9w22MO 3LsHCaVv8jbCpnoFdxYYp7GFCsnSc/YLajA74VlLbBRo5OLVM5/bmUvz7Bi7lDyA whQTTnBPRlDzPra8jQnSj40JSt4dt6MlgGU6mNg2/yHW1pJUua1mSKWg1DMVdQ2Q ETPLo1+lswSzI0/FKQr9BxG38jzcBUh0+XD+rI3yl1ACJwOhiKe0hFFsMOEDZwM+ R5OQe1l1nWvGBy9i3nDYEisTWwwUKnV00YHz4tnMfWiiDhGgpgkRD9+AW80yoC0T LK+nClPijB63JGw7GdmNHf3VinmZNiGdVUY7cVCFqEHDREODNxLFqjCMtvAXk0Zu VLIoVc0Wkehg+lubBXZykb3/GSI4dYD8JS+gZ5YW4jh3KyUf3TyHDEMhiTKQLxrb 6wmPAV3TXbJUxa7Cgk3i =evOx -----END PGP SIGNATURE-----
participants (2)
-
Henri Verbeet -
Stefan Dösinger