Re: winemac: Implement GetDeviceGammaRamp() and SetDeviceGammaRamp().

[André Hentschel]

Am 18.03.2013 04:41, schrieb Ken Thomases:
> ---
> dlls/winemac.drv/display.c |  131 ++++++++++++++++++++++++++++++++++++++++++++
> dlls/winemac.drv/gdi.c     |    4 +-
> dlls/winemac.drv/macdrv.h  |    2 +
> 3 files changed, 135 insertions(+), 2 deletions(-)

Hi,
wrt macdrv_SetDeviceGammaRamp, the X11 driver has some validation in xvidmode.c->ComputeGammaFromRamp() because windows doesn't allow every ramp.
It might happen that apps try bad ramps and the screen simply gets dark without validation.
I'll see if i can copy/move the validation to gdi32 where the driver function normally get's called so that the validation is driver independent.


-- 

Best Regards, André Hentschel

winemac: Implement GetDeviceGammaRamp() and SetDeviceGammaRamp().

[Ken Thomases]

On Mar 20, 2013, at 1:33 PM, André Hentschel wrote:
> Am 18.03.2013 04:41, schrieb Ken Thomases:
> > ---
> > dlls/winemac.drv/display.c |  131 ++++++++++++++++++++++++++++++++++++++++++++
> > dlls/winemac.drv/gdi.c     |    4 +-
> > dlls/winemac.drv/macdrv.h  |    2 +
> > 3 files changed, 135 insertions(+), 2 deletions(-)
>
> Hi,
> wrt macdrv_SetDeviceGammaRamp, the X11 driver has some validation in xvidmode.c->ComputeGammaFromRamp() because windows doesn't allow every ramp.
> It might happen that apps try bad ramps and the screen simply gets dark without validation.

Ah, interesting.  I missed that.
> I'll see if i can copy/move the validation to gdi32 where the driver function normally get's called so that the validation is driver independent.

Thanks!

-Ken