Re: mlang.dll implementation fix
Hi and welcome, Patches should be sent included in the mail. Adding tests is recommended. You can follow status at http://source.winehq.org/patches/. But currently we're in code freeze so you may have to wait Wine 1.6. Christian 2013/6/19 Bartosz <gang65(a)poczta.onet.pl>
My name is Bartosz and I would like to start hacking wine. At beginning I implemented BreakLine methods (available in mlang.dll): http://msdn.microsoft.com/en-us/library/aa741037%28v=vs.85%29.aspx
I prepared patch which is available at: http://bugs.winehq.org/attachment.cgi?id=44854&action=diff http://bugs.winehq.org/show_bug.cgi?id=32126
Could you please take a look at these methods and push it into git repo?
Should I write tests for that?
Thanks in advance Bartosz
Hi. Here is the patch attached to mail. I will prepare tests soon. Best Regards Bartosz 2013/6/19 Christian Costa <titan.costa(a)gmail.com>:
Hi and welcome,
Patches should be sent included in the mail. Adding tests is recommended. You can follow status at http://source.winehq.org/patches/. But currently we're in code freeze so you may have to wait Wine 1.6.
Christian
2013/6/19 Bartosz <gang65(a)poczta.onet.pl>
My name is Bartosz and I would like to start hacking wine. At beginning I implemented BreakLine methods (available in mlang.dll): http://msdn.microsoft.com/en-us/library/aa741037%28v=vs.85%29.aspx
I prepared patch which is available at: http://bugs.winehq.org/attachment.cgi?id=44854&action=diff http://bugs.winehq.org/show_bug.cgi?id=32126
Could you please take a look at these methods and push it into git repo?
Should I write tests for that?
Thanks in advance Bartosz
participants (2)
-
Bartosz -
Christian Costa