Re: [2/2] server: Remove a not necessary check for 'current' being not NULL.

[Alexandre Julliard]

Dmitry Timoshkov <dmitry(a)baikal.ru> writes:
> 'current' is already dereferenced twice before this point.
> ---
>  server/request.c | 23 ++++++++++-------------
>  1 file changed, 10 insertions(+), 13 deletions(-)

You can't do that.

-- 
Alexandre Julliard
julliard(a)winehq.org

[2/2] server: Remove a not necessary check for 'current' being not NULL.

[Dmitry Timoshkov]

Alexandre Julliard <julliard(a)winehq.org> wrote:
> > 'current' is already dereferenced twice before this point.
> > ---
> >  server/request.c | 23 ++++++++++-------------
> >  1 file changed, 10 insertions(+), 13 deletions(-)
>
> You can't do that.

Is there a reason why? Can 'current' be set to NULL by a request handler?

-- 
Dmitry.

[2/2] server: Remove a not necessary check for 'current' being not NULL.

[Alexandre Julliard]

Dmitry Timoshkov <dmitry(a)baikal.ru> writes:
> Alexandre Julliard <julliard(a)winehq.org> wrote:
> > > 'current' is already dereferenced twice before this point.
> > > ---
> > >  server/request.c | 23 ++++++++++-------------
> > >  1 file changed, 10 insertions(+), 13 deletions(-)
> >
> > You can't do that.
>
> Is there a reason why? Can 'current' be set to NULL by a request handler?

Yes.

-- 
Alexandre Julliard
julliard(a)winehq.org

[2/2] server: Remove a not necessary check for 'current' being not NULL.

[Dmitry Timoshkov]

Alexandre Julliard <julliard(a)winehq.org> wrote:
> > > > 'current' is already dereferenced twice before this point.
> > > > ---
> > > >  server/request.c | 23 ++++++++++-------------
> > > >  1 file changed, 10 insertions(+), 13 deletions(-)
> > >
> > > You can't do that.
> >
> > Is there a reason why? Can 'current' be set to NULL by a request handler?
>
> Yes.

I see that kill_thread() does that if a being killed thread is current.
Thanks.

-- 
Dmitry.