Re: [PATCH v3 1/6] reg.exe/tests: Parameterise error messages

[Alexandre Julliard]

Jonathan Vollebregt <jnvsor(a)gmail.com> writes:
> Also use %u for DWORD instead of %d

It's not worth changing that sort of thing, the expected value is in
general not useful. In the tests that you are modifying you can get rid
of it, otherwise leave them alone.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH v3 1/6] reg.exe/tests: Parameterise error messages

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-10-23 09:14, schrieb Alexandre Julliard:
> Jonathan Vollebregt <jnvsor(a)gmail.com> writes:
> > Also use %u for DWORD instead of %d
>
> It's not worth changing that sort of thing, the expected value is
> in general not useful.
> https://www.winehq.org/docs/winedev-guide/testing-error-messages kinda
> puts that rule in writing, although it took me a while to find it.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJUSM2uAAoJEN0/YqbEcdMwNGIP/jBTa3cLLXdsQRBoD7fGL82Q
Ojbh08inY5jQB2p+65k+oAOPpZZOmbQuhiXCfgx2st8+gLNsbJOOiZhYbZz6xMmW
60B7EiA/4upzEJzU2nCSd5cXdBC5VmMecTd+1UpXiOzfMNV3eq3kOT7o3DdQdUzQ
vV9+ao+LWUt6Ms3/jVk153YiN2rphomK7pL9XJcbHvTRUw6uFsKGqcilP/Z3WquU
KFlqaYm7OOVPU1c15ucQc0C9ysjqrpjA0fWzfBM7AYF8jy+uzwAyYIGD7ma9cYF2
2Ur9Y7ERnMmP5fwUXVtvuLdot3a5clZ7/QMAgtsRFjnV+Qq6SWu+lSRBd9T0cFCU
GKEXsLCoNOMddDBnVVqDcPiXCKAVXUiCYLWZc1VuIgOn33d0Re4+AhaNGZA7vAAO
h6jS4eESJbL17HOgnaFJ8p2ujRac0guPElqXbUz4tXIJ7CZt1vTIXDFJLycyPosm
8Fs7bhrzQc/i9WormllgHsT5nFnOEE+mJyWbYh0KaEGou/lU0olpTQyLbUrNT57C
ZPhWA/1c7ozM6zX5rXnt2Qwi5Fyf0IJecGzOIHq8P/M3UtuqiSB3i9JgH5otTMQl
c4bo9UQ7ZQsw40GXwzN6znGCoDPwI8VK6gXjiL6hKr/khUbCvkCQcTEPsp8viz4m
/IdP8hOVDTmJiHnvhEKn
=CKbf
-----END PGP SIGNATURE-----

[PATCH v3 1/6] reg.exe/tests: Parameterise error messages

[Henri Verbeet]

On 23 October 2014 11:43, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote:
> Am 2014-10-23 09:14, schrieb Alexandre Julliard:
> > Jonathan Vollebregt <jnvsor(a)gmail.com> writes:
> > > Also use %u for DWORD instead of %d
> >
> > It's not worth changing that sort of thing, the expected value is
> > in general not useful.
> > https://www.winehq.org/docs/winedev-guide/testing-error-messages kinda
> > puts that rule in writing, although it took me a while to find it.

I think it mostly just follows from the general principle of not
adding useless code. Which shouldn't be unique to Wine, really.