Re:SetConsoleTitle

[Eric Pouech]

the server just misses the instruction to notify the wineconsole program of a change in the title... I'll submit a patch tonight
so you can safely implement the TITLE command

you can try adding this in server/console.c (function set_console_input_info, just after the new title is set when the mask 
has the SET_CONSOLE_INPUT_INFO_TITLE bit set). This should do it.

	    evt.event = CONSOLE_RENDERER_TITLE_EVENT;
	    console_input_events_append( console->evt, &evt );

A+
> Question - I modified WCMD to support the 'TITLE' command which passed it
> through to SetConsoleTitle(A), and a simple program which subsequently calls
> GetConsoleTitle shows that the new value is in effect, but I dont see any
> window title for the WCMD shell.
>
> Is this a limitation of the console handling? (I tried with Managed='Y' and
> with no Managed line in my config file and the result was the same)
>
> Should I submit the patch to support the title command even though it will
> not be displayed currently? Its simple enough to do.
>
> Regards,
> Jason

---------------     
Eric Pouech 
(http://perso.wanadoo.fr/eric.pouech/)
The future will be better tomorrow, 
Vice President Dan Quayle


____________________________________________________________
Faites un voeu et puis Voila ! www.voila.fr 
Avec Voila Mail, consultez vos e-mails sur votre mobile Wap.

SetConsoleTitle

[Ann and Jason Edmeades]

Hi Eric,

Yes, the following patch made all my code work first time :-)

Index: console.c
===================================================================
RCS file: /home/wine/wine/server/console.c,v
retrieving revision 1.36
diff -u -r1.36 console.c
--- console.c	26 Apr 2002 19:05:17 -0000	1.36
+++ console.c	3 May 2002 18:17:54 -0000
@@ -532,6 +532,8 @@
             new_title[len / sizeof(WCHAR)] = 0;
             if (console->title) free( console->title );
             console->title = new_title;
+            evt.event = CONSOLE_RENDERER_TITLE_EVENT;
+            console_input_events_append( console->evt, &evt );
         }
     }
     if (req->mask & SET_CONSOLE_INPUT_INFO_HISTORY_MODE)

Again thanks for your help and can you submit this and the previous patch
(for the missing lines in the console from dir /s /w). I'll send mine in
now.

Regards,
Jason


-----Original Message-----
From: Eric Pouech [mailto:eric.pouech(a)voila.fr]
Sent: 02 May 2002 07:49
To: us(a)the-edmeades.demon.co.uk
Cc: wine-devel(a)winehq.com
Subject: Re:SetConsoleTitle


the server just misses the instruction to notify the wineconsole program of
a change in the title... I'll submit a patch tonight
so you can safely implement the TITLE command

you can try adding this in server/console.c (function
set_console_input_info, just after the new title is set when the mask
has the SET_CONSOLE_INPUT_INFO_TITLE bit set). This should do it.

	    evt.event = CONSOLE_RENDERER_TITLE_EVENT;
	    console_input_events_append( console->evt, &evt );

A+