[PATCH v3 2/2] oleaut32: Retrieve funcdesc from TLB by memberid and invkind.

[Porot Mo]

This allows ITypeInfo::GetDllEntry() to search exact property
access functions which share same memberid.

Signed-off-by: Porot Mo <porotmjp(a)gmail.com>
---
v3: spilt tests and fix

 dlls/oleaut32/typelib.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

[Porot Mo]

Hi everyone, Any advice to improve the patch so it can be accepted?

Porot Mo


Porot Mo

On Tue, 9 Jun 2020 at 10:58, Porot Mo <porotmjp(a)gmail.com> wrote:
> This allows ITypeInfo::GetDllEntry() to search exact property
> access functions which share same memberid.
>
> Signed-off-by: Porot Mo <porotmjp(a)gmail.com>
> ---
> v3: spilt tests and fix
>
> dlls/oleaut32/typelib.c | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)

[Huw Davies]

On Wed, Jun 10, 2020 at 09:57:44AM +0800, Porot Mo wrote:
> Hi everyone, Any advice to improve the patch so it can be accepted?

Hi,

Your first patch is producing failures when running under Wine:
https://testbot.winehq.org/JobDetails.pl?Key=73095

They need to pass at this stage even if they're
fixed in the next patch.  So you should add
todo_wine blocks around the failing tests.
You will then remove these blocks in the
second patch.

Huw.

[Porot Mo]

Thanks. I will add todo_wine macro in the next version patch

On Wed, 10 Jun 2020 at 15:59, Huw Davies <huw(a)codeweavers.com> wrote:
> On Wed, Jun 10, 2020 at 09:57:44AM +0800, Porot Mo wrote:
> > Hi everyone, Any advice to improve the patch so it can be accepted?
>
> Hi,
>
> Your first patch is producing failures when running under Wine:
> https://testbot.winehq.org/JobDetails.pl?Key=73095
>
> They need to pass at this stage even if they're
> fixed in the next patch.  So you should add
> todo_wine blocks around the failing tests.
> You will then remove these blocks in the
> second patch.
>
> Huw.