Re: [PATCH 3/3] include: Add MCI_INTEGER64 and MCI_INTEGER3264 mci types. (try 2)

[Jacek Caban]

Hi Octavian,

On 9/1/10 7:45 PM, Octavian Voicu wrote:
> MCI_INTEGER64 is only defined for _WIN64 in DDK.
>
> MCI_INTEGER3264 is wine specific and will be needed because MCI_STATUS
> return type is MCI_INTEGER64 in 64-bit winmm.dll, and MCI_INTEGER
> in 32-bit winmm.dll.

That's not a reason to add Wine-specific defines in public header.

Jacek

[PATCH 3/3] include: Add MCI_INTEGER64 and MCI_INTEGER3264 mci types. (try 2)

[Octavian Voicu]

On Wed, Sep 1, 2010 at 9:20 PM, Jacek Caban <jacek(a)codeweavers.com> wrote:
> On 9/1/10 7:45 PM, Octavian Voicu wrote:
> > MCI_INTEGER64 is only defined for _WIN64 in DDK.
> >
> > MCI_INTEGER3264 is wine specific and will be needed because MCI_STATUS
> > return type is MCI_INTEGER64 in 64-bit winmm.dll, and MCI_INTEGER
> > in 32-bit winmm.dll.
>
> That's not a reason to add Wine-specific defines in public header.

There are two reasons for which I considered it appropriate:

1. In a future patch I will change MCI_INTEGER to MCI_INTEGER3264 in
all the *_res.rc files related to mci. They already include mmddk.h,
and there is no other private include header afaik.

2. I saw there were some other #ifdef __WINESRC__ in mmddk.h, so I
used the same pattern (I'm guessing it won't be available to
applications compiling with this header, just when compiling wine).

If this is not the correct approach, can you suggest a better one? I
definitely need a constant like MCI_INTEGER3264 to replace all the
MCI_INTEGERs in MCI_STATUS return type (adding one #ifdef for each
status command would be overkill imho).

Octavian

[PATCH 3/3] include: Add MCI_INTEGER64 and MCI_INTEGER3264 mci types. (try 2)

[Alexandre Julliard]

Octavian Voicu <octavian.voicu(a)gmail.com> writes:
> If this is not the correct approach, can you suggest a better one? I
> definitely need a constant like MCI_INTEGER3264 to replace all the
> MCI_INTEGERs in MCI_STATUS return type (adding one #ifdef for each
> status command would be overkill imho).

You can add the #define at the top of the .rc files that need it.

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 3/3] include: Add MCI_INTEGER64 and MCI_INTEGER3264 mci types. (try 2)

[Octavian Voicu]

On Thu, Sep 2, 2010 at 10:17 AM, Alexandre Julliard <julliard(a)winehq.org> wrote:
> Octavian Voicu <octavian.voicu(a)gmail.com> writes:
> > If this is not the correct approach, can you suggest a better one? I
> > definitely need a constant like MCI_INTEGER3264 to replace all the
> > MCI_INTEGERs in MCI_STATUS return type (adding one #ifdef for each
> > status command would be overkill imho).
>
> You can add the #define at the top of the .rc files that need it.

OK, I've resent the patch as try 3 with only the MCI_INTEGER64 part.

Octavian