[PATCH] winegstreamer: don't set active during test-play

[Anton Romanov]

Even the code above this says it wasn't meant to be set

Signed-off-by: Anton Romanov <theli.ua(a)gmail.com>
---
 dlls/winegstreamer/gstdemux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c
index a19c64ff72..0b3db944b9 100644
--- a/dlls/winegstreamer/gstdemux.c
+++ b/dlls/winegstreamer/gstdemux.c
@@ -1188,7 +1188,7 @@ static HRESULT GST_Connect(GSTInPin *pPin, IPin *pConnectPin, ALLOCATOR_PROPERTI
 
     /* don't set active during test-play, as we don't want to push/pull data
      * from the source yet */
-    gst_pad_set_active(This->my_src, 1);
+    gst_pad_set_active(This->my_src, 0);
 
     This->nextofs = This->nextpullofs = 0;
     return hr;
-- 
2.15.1

On 01/22/2018 12:50 AM, Anton Romanov wrote:
> Even the code above this says it wasn't meant to be set
>
> Signed-off-by: Anton Romanov <theli.ua(a)gmail.com>
> ---
>   dlls/winegstreamer/gstdemux.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c
> index a19c64ff72..0b3db944b9 100644
> --- a/dlls/winegstreamer/gstdemux.c
> +++ b/dlls/winegstreamer/gstdemux.c
> @@ -1188,7 +1188,7 @@ static HRESULT GST_Connect(GSTInPin *pPin, IPin *pConnectPin, ALLOCATOR_PROPERTI
>
> /* don't set active during test-play, as we don't want to push/pull data
>        * from the source yet */
> -    gst_pad_set_active(This->my_src, 1);
> +    gst_pad_set_active(This->my_src, 0);
>
> This->nextofs = This->nextpullofs = 0;
>       return hr;

No, this is correct. The comment above is from an earlier change which 
moved that call downward from before the test-play.

What needs to be done instead is return if decodebin failed, but I think 
the condition for this may need to be amended. I'm working on a fix.