Re: kernel32/tests: Fix a failing test in vista
"Nicolas Le Cam" <niko.lecam(a)gmail.com> wrote:
Vista introduced new flags for CompareString, as stated in [1]. The value defined for LINGUISTIC_IGNORECASE is 0x10. So the invalid flag test don't fail as expected starting from this platform.
LINGUISTIC_IGNORECASE should be added first instead of using a hex value, and CompareString implementation should handle that flag as well. -- Dmitry.
(resending as I forgot to CC to wine-devel) This test is here to test handling of incorrect flags. So a hex value is necessary as even any combination of know values are correct according to msdn. Sorry if I wasn't clear enough. I'm new to wine and English isn't my first language. I can add LINGUISTIC_IGNORECASE and other new definitions and try to implement handling of those new flags in CompareString but IMHO it's a different task. 2008/7/21 Dmitry Timoshkov <dmitry(a)codeweavers.com>:
"Nicolas Le Cam" <niko.lecam(a)gmail.com> wrote:
Vista introduced new flags for CompareString, as stated in [1].
The value defined for LINGUISTIC_IGNORECASE is 0x10. So the invalid flag test don't fail as expected starting from this platform.
LINGUISTIC_IGNORECASE should be added first instead of using a hex value, and CompareString implementation should handle that flag as well.
-- Dmitry.
participants (2)
-
Dmitry Timoshkov -
Nicolas Le Cam