Re: [PATCH] shlwapi: initial implement of SHAutoComplete (Retry)

[Nikolay Sivov]

On 5/25/2010 03:29, Hirofumi Katayama wrote:
> See attachment.

Hi.
> +        list = (LPWSTR) malloc(len);
> +        free(list);
> Use HeapAlloc()/HeapFree() for that and others allocations.
> +    fUnicode = IsWindowUnicode(hwndEdit);
> +    if (fUnicode)
> +        pProp = (AUTOCOMPLETEPROP *) GetPropW(hwndEdit, szPropNameW);
> +    else
> +        pProp = (AUTOCOMPLETEPROP *) GetPropA(hwndEdit, szPropNameA);
> This is unrelated thing. You can use GetPropW for non-Unicode windows as 
> well.