Re: msi [6/6]: Rewrite the PublishProduct test to only check the registry changes

[Paul Vriens]

James Hawkins wrote:
> Hi,
>
> Changelog:
> * Rewrite the PublishProduct test to only check the registry changes.
>
> dlls/msi/tests/install.c |  148 +++++++++++++++++++++++++++-------------------
>  1 files changed, 87 insertions(+), 61 deletions(-)
>
> ------------------------------------------------------------------------

Hi James,

I've noticed some (new) failure for the msi/install test:

+        CHECK_DEL_REG_STR(hkey, "Clients", ":");
+    }

This one is a REG_MULTI_SZ on my W2K3 box (and from the looks of the test 
results probably the same on XP/W2K3). The macro CHECK_DEL_REG_STR or actually 
the function check_reg_str checks only for REG_SZ and REG_EXPAND_SZ.

I'm not sure what the fix should be:

- replace the check for REG_EXPAND_SZ by REG_MULTI_SZ
- add the REG_MULTI_SZ as well to the check

-- 
Cheers,

Paul.

msi [6/6]: Rewrite the PublishProduct test to only check the registry changes

[James Hawkins]

On Sun, Jun 22, 2008 at 7:52 AM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote:
> James Hawkins wrote:
> > Hi,
> >
> > Changelog:
> > * Rewrite the PublishProduct test to only check the registry changes.
> >
> > dlls/msi/tests/install.c |  148
> > +++++++++++++++++++++++++++-------------------
> >  1 files changed, 87 insertions(+), 61 deletions(-)
> >
> > ------------------------------------------------------------------------
>
> Hi James,
>
> I've noticed some (new) failure for the msi/install test:
>
> +        CHECK_DEL_REG_STR(hkey, "Clients", ":");
> +    }
>
> This one is a REG_MULTI_SZ on my W2K3 box (and from the looks of the test
> results probably the same on XP/W2K3). The macro CHECK_DEL_REG_STR or
> actually the function check_reg_str checks only for REG_SZ and
> REG_EXPAND_SZ.

I already have a patch to send in.

-- 
James Hawkins