Re: msxml: Implement cloneNode and correct insertBefore
On 11/13/07, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote:
Hi James, Thanks for the pointers.
I resend the patches shortly. Is there an easy way to split a Diff up? via git? More to the point changes to a single file (without have to backup it up every change)
I just get frustrated with try to keep lots of diffs around.
mailing list etiquette: make sure to bottom-post on this ML and CC wine-devel so others can share in the information exchange. To answer your question, you have to get into the git mindset. That is, you make one fix, commit the fix, write the next fix, etc. It's really a development change. You should know what to fix before you go in to fix it, not hack around until an app works. -- James Hawkins
"James Hawkins" <truiken(a)gmail.com> wrote in message news:22821af30711131811g27868935uf3423253ddaf5bcd(a)mail.gmail.com...
On 11/13/07, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote:
Hi James, Thanks for the pointers.
I resend the patches shortly. Is there an easy way to split a Diff up? via git? More to the point changes to a single file (without have to backup it up every change)
I just get frustrated with try to keep lots of diffs around.
mailing list etiquette: make sure to bottom-post on this ML and CC wine-devel so others can share in the information exchange.
To answer your question, you have to get into the git mindset. That is, you make one fix, commit the fix, write the next fix, etc. It's really a development change. You should know what to fix before you go in to fix it, not hack around until an app works.
-- James Hawkins
Thanks again. I should of read http://wiki.winehq.org/GitWine first. Ill resend patches shortly. Best Regards Alistair Leslie-Hughes
Hi James, James Hawkins schreef:
mailing list etiquette: make sure to bottom-post on this ML and CC wine-devel so others can share in the information exchange.
To answer your question, you have to get into the git mindset. That is, you make one fix, commit the fix, write the next fix, etc. It's really a development change. You should know what to fix before you go in to fix it, not hack around until an app works.
Strictly speaking not entirely true, a lot of the times I first hack around till my app works before cleaning it up and sending in a proper fix. You are right that missing the clean-up will mean that the code won't be accepted into wine, sometimes that is even more work then the stuff needed to make it work. A: Top posting
Q: What is the most annoying thing in the world?
Cheers, Maarten
participants (3)
-
Alistair Leslie-Hughes -
James Hawkins -
Maarten Lankhorst