[PATCH 1/5] d2d1: Release bitmap on d2d_device_context_SetTarget() error path.

[Zhiyi Zhang]

Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com>
---
 dlls/d2d1/device.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/d2d1/device.c b/dlls/d2d1/device.c
index ce74d7c1582..47da411f3b6 100644
--- a/dlls/d2d1/device.c
+++ b/dlls/d2d1/device.c
@@ -2051,6 +2051,7 @@ static void STDMETHODCALLTYPE d2d_device_context_SetTarget(ID2D1DeviceContext *i
 
     if (!(bitmap_impl->options & D2D1_BITMAP_OPTIONS_TARGET))
     {
+        ID2D1Bitmap_Release(bitmap);
         d2d_device_context_set_error(context, D2DERR_INVALID_TARGET);
         return;
     }
-- 
2.32.0

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=110301

Your paranoid android.


=== debian11 (64 bit WoW report) ===

d2d1:
d2d1.c:6809: Test failed: d2d1.c:10292: Test marked todo: Test 1: Got unexpected output bounds {-1.00000000e+000, -1.00000000e+000, -1.00000000e+000, -1.00000000e+000}, expected {4.00000000e+000, 4.00000000e+000, 8.00000000e+000, 8.00000000e+000}.
d2d1.c:6833: Test failed: d2d1.c:10292: Test marked todo: Test 5: d2d1.c:6833: Test failed: Figure does not match.

Report validation errors:
d2d1:d2d1 is missing some skip messages

[Henri Verbeet]

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>