[PATCH 1/3] winevulkan: Remove duplicate format_string in make_vulkan
From: Michał Janiszewski <janisozaur(a)gmail.com> --- dlls/winevulkan/make_vulkan | 3 --- 1 file changed, 3 deletions(-) diff --git a/dlls/winevulkan/make_vulkan b/dlls/winevulkan/make_vulkan index ec861bda7d..375614a4d4 100755 --- a/dlls/winevulkan/make_vulkan +++ b/dlls/winevulkan/make_vulkan @@ -1332,9 +1332,6 @@ class VkParam(object): return self._direction - def format_string(self): - return self.format_str - def dispatch_table(self): """ Return functions dispatch table pointer for dispatchable objects. """ -- 2.19.1
From: Michał Janiszewski <janisozaur(a)gmail.com> --- dlls/winevulkan/make_vulkan | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/winevulkan/make_vulkan b/dlls/winevulkan/make_vulkan index 375614a4d4..e6bdbc93cf 100755 --- a/dlls/winevulkan/make_vulkan +++ b/dlls/winevulkan/make_vulkan @@ -1160,7 +1160,7 @@ class VkParam(object): self._set_conversions() def __repr__(self): - return "{0} {1} {2} {3} {4}".format(self.const, self.type, self.pointer, self.name, self.array_len, self.dyn_array_len) + return "{0} {1} {2} {3} {4} {5}".format(self.const, self.type, self.pointer, self.name, self.array_len, self.dyn_array_len) @staticmethod def from_xml(param, types): -- 2.19.1
Signed-off-by: Michał Janiszewski <janisozaur(a)gmail.com> On Fri, 12 Oct 2018 at 00:07, <janisozaur(a)gmail.com> wrote:
From: Michał Janiszewski <janisozaur(a)gmail.com>
--- dlls/winevulkan/make_vulkan | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/winevulkan/make_vulkan b/dlls/winevulkan/make_vulkan index 375614a4d4..e6bdbc93cf 100755 --- a/dlls/winevulkan/make_vulkan +++ b/dlls/winevulkan/make_vulkan @@ -1160,7 +1160,7 @@ class VkParam(object): self._set_conversions()
def __repr__(self): - return "{0} {1} {2} {3} {4}".format(self.const, self.type, self.pointer, self.name, self.array_len, self.dyn_array_len) + return "{0} {1} {2} {3} {4} {5}".format(self.const, self.type, self.pointer, self.name, self.array_len, self.dyn_array_len)
@staticmethod def from_xml(param, types): -- 2.19.1
-- Michal Janiszewski
Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com>
From: Michał Janiszewski <janisozaur(a)gmail.com> Signed-off-by: Michał Janiszewski <janisozaur(a)gmail.com> --- dlls/winevulkan/make_vulkan | 2 -- 1 file changed, 2 deletions(-) diff --git a/dlls/winevulkan/make_vulkan b/dlls/winevulkan/make_vulkan index e6bdbc93cf..3e2c367a98 100755 --- a/dlls/winevulkan/make_vulkan +++ b/dlls/winevulkan/make_vulkan @@ -1775,10 +1775,8 @@ class ConversionFunction(object): if self.direction == Direction.OUTPUT: params = ["const {0}_host *in".format(self.type), "{0} *out".format(self.type), "uint32_t count"] - return_type = self.type else: params = ["const {0} *in".format(self.type), "{0} *out_host".format(self.type), "uint32_t count"] - return_type = "{0}_host".format(self.type) # Generate function prototype. body = "static inline void {0}(".format(self.name) -- 2.19.1
Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com>
Signed-off-by: Michał Janiszewski <janisozaur(a)gmail.com> Sorry, I thought I applied it to all the patches. Done now. On Fri, 12 Oct 2018 at 16:53, Józef Kucia <joseph.kucia(a)gmail.com> wrote:
On Fri, Oct 12, 2018 at 12:08 AM <janisozaur(a)gmail.com> wrote:
From: Michał Janiszewski <janisozaur(a)gmail.com>
---
The patch looks good to me, but Signed-off-by is missing.
-- Michal Janiszewski
participants (3)
-
janisozaur＠gmail.com -
Józef Kucia -
Michał Janiszewski