Re: wined3d: Fix for buggy programs using ortho matrix with no z range

[Stefan Dösinger]

Am Dienstag, 29. April 2008 19:04:55 schrieb Jens Albretsen:
> Changelog:
> Fix for old games that sets a Ortho matrix with z range from 0-0 or in
> other word with no range, which does'nt make any sense but they do it
> anyway.
> I think a test case for this would be good.

wined3d: Fix for buggy programs using ortho matrix with no z range

[Jens Albretsen]

On Tuesday 29 April 2008 22:25:48 Stefan Dösinger wrote:
> Am Dienstag, 29. April 2008 19:04:55 schrieb Jens Albretsen:
> > Changelog:
> > Fix for old games that sets a Ortho matrix with z range from 0-0 or in
> > other word with no range, which does'nt make any sense but they do it
> > anyway.
>
> I think a test case for this would be good.

A quick one is Lego Island, just forget to put in the disc a there is black 
screen, with this patch is shows a message to put the cdrom in the drive.

Is it something like this?

create (1,1) rendertarget
clear rendertarget with black
setup ortho with no range
draw something with white
check rendertarget for any pixel drawn, if black test fails
or what?

wined3d: Fix for buggy programs using ortho matrix with no z range

[Stefan Dösinger]

Am Mittwoch, 30. April 2008 07:21:19 schrieb Jens Albretsen:
> A quick one is Lego Island, just forget to put in the disc a there is black
> screen, with this patch is shows a message to put the cdrom in the drive.
>
> Is it something like this?
>
> create (1,1) rendertarget
> clear rendertarget with black
> setup ortho with no range
> draw something with white
> check rendertarget for any pixel drawn, if black test fails
> or what?
> Take a look at dlls/d3d9/tests/visual.c

Also, instead of setting the depth range to min;min + 1 it might be better to 
fall back to the no-depth-range codepath that is used if the app ever drawed 
untransformed geomentry. That's the device->untransformed check near the 
glOrtho calls.