Re: "typos" on some include files
"Marcos Gutiérrez Batz" <sacrom(a)gmail.com> wrote:
$ diff -up liboleaut32.def /usr/lib/wine/liboleaut32.def --- liboleaut32.def 2007-08-23 16:15:48.000000000 +0200 +++ /usr/lib/wine/liboleaut32.def 2007-10-15 00:48:35.000000000 +0200 @@ -366,7 +366,6 @@ EXPORTS OleCreatePictureIndirect(a)16 @419 OleCreateFontIndirect(a)12 @420 OleTranslateColor(a)12 @421 - OleLoadPictureFile(a)12 @422 OleLoadPicturePath(a)24 @424 VarUI4FromI8(a)12 @425 VarUI4FromUI8(a)12 @426
Also you can't just add an entry to the .def file, it's auto generated. You have to add a stub to the source file, and change the 'stub' entry in the .spec file. -- Dmitry.
I'll try to find the correct files to add the stub and then send the patch for that! Dmitry Timoshkov wrote:
"Marcos Gutiérrez Batz" <sacrom(a)gmail.com> wrote:
$ diff -up liboleaut32.def /usr/lib/wine/liboleaut32.def --- liboleaut32.def 2007-08-23 16:15:48.000000000 +0200 +++ /usr/lib/wine/liboleaut32.def 2007-10-15 00:48:35.000000000 +0200 @@ -366,7 +366,6 @@ EXPORTS OleCreatePictureIndirect(a)16 @419 OleCreateFontIndirect(a)12 @420 OleTranslateColor(a)12 @421 - OleLoadPictureFile(a)12 @422 OleLoadPicturePath(a)24 @424 VarUI4FromI8(a)12 @425 VarUI4FromUI8(a)12 @426
Also you can't just add an entry to the .def file, it's auto generated. You have to add a stub to the source file, and change the 'stub' entry in the .spec file.
Added OleLoadPictureFile stub. Dmitry Timoshkov wrote:
"Marcos Gutiérrez Batz" <sacrom(a)gmail.com> wrote:
$ diff -up liboleaut32.def /usr/lib/wine/liboleaut32.def --- liboleaut32.def 2007-08-23 16:15:48.000000000 +0200 +++ /usr/lib/wine/liboleaut32.def 2007-10-15 00:48:35.000000000 +0200 @@ -366,7 +366,6 @@ EXPORTS OleCreatePictureIndirect(a)16 @419 OleCreateFontIndirect(a)12 @420 OleTranslateColor(a)12 @421 - OleLoadPictureFile(a)12 @422 OleLoadPicturePath(a)24 @424 VarUI4FromI8(a)12 @425 VarUI4FromUI8(a)12 @426
Also you can't just add an entry to the .def file, it's auto generated. You have to add a stub to the source file, and change the 'stub' entry in the .spec file.
$ diff -up /usr/src/wine/dlls/oleaut32/stubs.c stubs.c --- /usr/src/wine/dlls/oleaut32/stubs.c 2007-07-27 17:11:43.000000000 +0200 +++ stubs.c 2007-10-24 15:39:58.000000000 +0200 @@ -54,3 +54,15 @@ HRESULT WINAPI OleCreatePropertyFrame( pPageClsID, (int)lcid,dwReserved,pvReserved); return S_OK; } + +/*********************************************************************** + * OleLoadPictureFile (OLEAUT32.422) + */ +HRESULT WINAPI HRESULT OleLoadPictureFile( + VARIANT varFileName, + LPDISPATCH *lplpdispPicture ) +{ + FIXME("(%p,%p), not implemented (oleaut32.dll)\n", + varFileName, lplpdispPicture); + return S_OK; +} $ diff -up /usr/src/wine/dlls/oleaut32/oleaut32.spec oleaut32.spec --- /usr/src/wine/dlls/oleaut32/oleaut32.spec 2007-07-27 17:11:43.000000000 +0200 +++ oleaut32.spec 2007-10-24 15:39:54.000000000 +0200 @@ -390,7 +390,7 @@ 419 stdcall OleCreatePictureIndirect(ptr ptr long ptr) 420 stdcall OleCreateFontIndirect(ptr ptr ptr) 421 stdcall OleTranslateColor(long long long) -422 stub OleLoadPictureFile +422 stdcall OleLoadPictureFile(ptr ptr) 423 stub OleSavePictureFile 424 stdcall OleLoadPicturePath(wstr ptr long long ptr ptr) 425 stdcall VarUI4FromI8(double ptr)
Oh God! Sorry about that! Dmitry Timoshkov wrote:
"Marcos Gutiérrez Batz" <sacrom(a)gmail.com> wrote:
+HRESULT WINAPI HRESULT OleLoadPictureFile( + VARIANT varFileName, + LPDISPATCH *lplpdispPicture )
HRESULT is duplicated.
$ diff -up /usr/src/wine/dlls/oleaut32/stubs.c stubs.c --- /usr/src/wine/dlls/oleaut32/stubs.c 2007-07-27 17:11:43.000000000 +0200 +++ stubs.c 2007-10-24 16:05:53.000000000 +0200 @@ -54,3 +54,15 @@ HRESULT WINAPI OleCreatePropertyFrame( pPageClsID, (int)lcid,dwReserved,pvReserved); return S_OK; } + +/*********************************************************************** + * OleLoadPictureFile (OLEAUT32.422) + */ +HRESULT WINAPI OleLoadPictureFile( + VARIANT varFileName, + LPDISPATCH *lplpdispPicture ) +{ + FIXME("(%p,%p), not implemented (oleaut32.dll)\n", + varFileName, lplpdispPicture); + return S_OK; +} $ diff -up /usr/src/wine/dlls/oleaut32/oleaut32.spec oleaut32.spec --- /usr/src/wine/dlls/oleaut32/oleaut32.spec 2007-07-27 17:11:43.000000000 +0200 +++ oleaut32.spec 2007-10-24 15:39:54.000000000 +0200 @@ -390,7 +390,7 @@ 419 stdcall OleCreatePictureIndirect(ptr ptr long ptr) 420 stdcall OleCreateFontIndirect(ptr ptr ptr) 421 stdcall OleTranslateColor(long long long) -422 stub OleLoadPictureFile +422 stdcall OleLoadPictureFile(ptr ptr) 423 stub OleSavePictureFile 424 stdcall OleLoadPicturePath(wstr ptr long long ptr ptr) 425 stdcall VarUI4FromI8(double ptr)
participants (2)
-
Dmitry Timoshkov -
Marcos Gutiérrez Batz