Re: [PATCH] wine.inf: Add quotes to webbrowser command key for mailto protocol.

[Qian Hong]

Hi Indrek,

On Mon, Dec 1, 2014 at 3:46 PM, Indrek Altpere <efbiaiinzinz(a)hotmail.com> wrote:
> Hello
>
> I even saw your patch in my inbox but it does not appear at
> https://source.winehq.org/patches/data/107949 for some reason, so I don't
> remember what lines you changed exactly so apologies if I seem to be
> re-stating things tou fixed already.
>
> When checking
> http://source.winehq.org/git/wine.git/blob_plain/HEAD:/loader/wine.inf.in
> there is also tons of other discrepancies (if you didn't already).
>
> Parameters are escaped with ""%1"" but not command:
> HKCR,Msi.Package\shell\Open\command,,2,"%11%\msiexec.exe /i ""%1"""
> HKCR,Msi.Package\shell\Repair\command,,2,"%11%\msiexec.exe /f ""%1"""
> HKCR,Msi.Package\shell\Uninstall\command,,2,"%11%\msiexec.exe /x ""%1"""
>
> Command itself is escaped:
> HKCR,htmlfile\shell\open\command,,2,"""%11%\winebrowser.exe"" -nohome"
>
> Neither command nor parameter is escaped:
> HKCR,txtfile\shell\open\command,,2,"%11%\notepad.exe %1"
> HKCR,txtfile\shell\print\command,,2,"%11%\notepad.exe /p %1"
> HKCR,wrifile\shell\open\command,,2,"%11%\wordpad.exe %1"
> HKCR,wrifile\shell\print\command,,2,"%11%\wordpad.exe /p %1"
>
> HKCR,rtffile\shell\open\command,,2,"%11%\wordpad.exe %1"
> HKCR,rtffile\shell\print\command,,2,"%11%\wordpad.exe /p %1"
>
> HKCR,inffile\shell\install\command,,2,"%11%\rundll32.exe
> setupapi,InstallHinfSection DefaultInstall 132 %1"
>
> HKCR,hlpfile\shell\open\command,,2,"%11%\winhlp32.exe %1"
>
> If winebrowser needs escaping because %11 contains a space then all other
> places also use %11 need that escaping. And if msiexec need to escape %1
> then all other places need it too don't they?

Thanks a lot for your comment, I'm investigating a bit more... Will
update later :)

-- 
Regards,
Qian Hong

-
http://www.codeweavers.com