Re: [PATCH 1/3] [cmd] move issues when overwriting files

[Alexandre Julliard]

Ann and Jason Edmeades <jason(a)edmeades.me.uk> writes:
> @@ -1709,8 +1709,13 @@ void WCMD_move (void)
>      WINE_TRACE("Source '%s'\n", wine_dbgstr_w(src));
>      WINE_TRACE("Dest   '%s'\n", wine_dbgstr_w(dest));
>
> -    /* If destination exists, prompt unless /Y supplied */
> -    if (GetFileAttributesW(dest) != INVALID_FILE_ATTRIBUTES) {
> +    /* If we have src == dest, skip moving this one */
> +    if (strcmpW(src,dest)==0) ok = FALSE;

You can't detect identical files by comparing file names.

-- 
Alexandre Julliard
julliard(a)winehq.org