Re: [PATCH 1/2] riched20: Implement IOleWindow interface.

[Nikolay Sivov]

On 16.03.2015 10:36, Jactry Zeng wrote:
> +  create_interfaces(&w, &reOle, &txtDoc, NULL);
> +  hres = IRichEditOle_GetClientSite(reOle, &clientSite);
> +  ok(hres == S_OK, "IRichEditOle_QueryInterface: 0x%08x\n", hres);
> +  refcount1 = get_refcount((IUnknown *)clientSite);
> +  todo_wine ok(refcount1 == 1, "got wrong ref count: %d\n", refcount1);
> +
> +  hres = IOleClientSite_QueryInterface(clientSite, &IID_IOleClientSite, (void **)&clientSite1);
> +  ok(hres == S_OK, "IOleClientSite_QueryInterface: 0x%08x\n", hres);
> +  ok(clientSite == clientSite1, "Should not return a new pointer.\n");
> +  refcount1 = get_refcount((IUnknown *)clientSite);
> +  todo_wine ok(refcount1 == 2, "got wrong ref count: %d\n", refcount1);

Hi, Jactry.

Do we have a test somewhere showing that IRichEditOle cannot be queried 
directly for IOleClientSite and IOleWindow?

[PATCH 1/2] riched20: Implement IOleWindow interface.

[Jactry Zeng]

Hi Nikolay,
2015-03-16 15:42 GMT+08:00 Nikolay Sivov <bunglehead(a)gmail.com>:
> Do we have a test somewhere showing that IRichEditOle cannot be queried

directly for IOleClientSite and IOleWindow?

No, there is not such a test in Wine.
But we really can't get IOleClientSite or IOleWindow from
IRichEditOle::QueryInterface directly.
Also can't get IRichEditOle from IOleClientSite::QueryInterface and
IOleWindow::QueryInterface.
Do you think we need add these tests into Wine?

Thanks for your comment!
-- 
Regards,
Jactry Zeng

[PATCH 1/2] riched20: Implement IOleWindow interface.

[Nikolay Sivov]

On 16.03.2015 11:12, Jactry Zeng wrote:
> Hi Nikolay,
> 2015-03-16 15:42 GMT+08:00 Nikolay Sivov <bunglehead(a)gmail.com
> <mailto:bunglehead(a)gmail.com>>:
> > Do we have a test somewhere showing that IRichEditOle cannot be
>
> queried directly for IOleClientSite and IOleWindow?
>
> No, there is not such a test in Wine.
> But we really can't get IOleClientSite or IOleWindow from
> IRichEditOle::QueryInterface directly.
> Also can't get IRichEditOle from IOleClientSite::QueryInterface and
> IOleWindow::QueryInterface.
> Do you think we need add these tests into Wine?

Sure, it won't hurt to have those. A separate patch for that would be fine.
> Thanks for your comment!
> --
> Regards,
> Jactry Zeng