Re: Bruno Jesus : ws2_32: Do not convert EAI_xxx return in case of success.

27 Dec 2013


      On Fri, Dec 27, 2013 at 5:31 PM, Alexandre Julliard <julliard(a)winehq.org> wrote:
...
Module: wine
Branch: master
Commit: fc5884c23296c0f121442d0832b0187074e95a10
...
@@ -5365,6 +5365,8 @@ static int convert_aiflag_u2w(int unixflags) {
 static int convert_eai_u2w(int unixret) {
     int i;
+    if (!unixret) return 0;
+
     for (i=0;ws_eai_map[i][0];i++)
         if (ws_eai_map[i][1] == unixret)
             return ws_eai_map[i][0];
Hi, Alexandre. I just would like to say that my patch was based on the
other use case of the convert_eai_u2w function, that is just call the
function to convert EAI results. Zero is not an EAI result (there is
no EAI_SUCCESS or something like that) so in my patch I just avoided
calling the conversion function. I'm talking about this use case:

http://source.winehq.org/source/dlls/ws2_32/socket.c#L5488

In summary, I think my original patch [1] could get a new reviewing.

[1] - http://source.winehq.org/patches/data/101198

Best wishes,
Bruno

    

Bruno Jesus