Re: msxml3/tests: Actually test the return values (PVS-Studio)

[Michael Stefaniuc]

Please ignore, wrong resend.

On 01/21/2015 10:48 AM, Michael Stefaniuc wrote:
> ---
>  dlls/msxml3/tests/domdoc.c | 1 +
>  dlls/msxml3/tests/schema.c | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
> index a23fb66..e669de4 100644
> --- a/dlls/msxml3/tests/domdoc.c
> +++ b/dlls/msxml3/tests/domdoc.c
> @@ -11085,6 +11085,7 @@ static void test_xmlns_attribute(void)
>      V_VT(&v) = VT_BSTR;
>      V_BSTR(&v) = _bstr_("urn:schemas-microsoft-com:datatypes");
>      hr = IXMLDOMAttribute_put_nodeValue(pAttribute, v);
> +    ok(hr == S_OK, "ret %08x\n", hr );
>
> hr = IXMLDOMElement_setAttributeNode(root, pAttribute, NULL);
>      ok(hr == S_OK, "ret %08x\n", hr );
> diff --git a/dlls/msxml3/tests/schema.c b/dlls/msxml3/tests/schema.c
> index f5d6fcd..be18fcf 100644
> --- a/dlls/msxml3/tests/schema.c
> +++ b/dlls/msxml3/tests/schema.c
> @@ -1292,6 +1292,7 @@ static void test_XDR_datatypes(void)
>
> VariantClear(&type);
>          hr = IXMLDOMNode_get_nodeTypedValue(node, &type);
> +        EXPECT_HR(hr, S_OK);
>          ok(V_VT(&type) == VT_BSTR, "got variant type %i\n", V_VT(&v));
>          VariantClear(&type);
>          IXMLDOMNode_Release(node);