msi.dll broken with yacc in current cvs

[Stefan Leichter]

Hello,

i can not compile msi.dll on one of my systems. make aborts with:

yacc -d -t ../../../wine/dlls/msi/sql.y
yacc: e - line 69 of "../../../wine/dlls/msi/sql.y", syntax error
%pure-parser
^
make[2]: *** [y.tab.c] Error 1
make[2]: Leaving directory `/usr/src/wine-build/dlls/msi'
make[1]: *** [msi] Error 2
make[1]: Leaving directory `/usr/src/wine-build/dlls'
make: *** [dlls] Error 2

The second system compiles fine. It uses bison instead of yacc.

Both systems are SuSE 7.3
> rpm -qa | grep -e bison -e yacc
> yacc-91.7.30-379
> bison-1.28-127

I know i can install bison and it will compile, but i think this needs to be 
fixed.

Bye Stefan

[Mike McCormack]

Hi Stefan,

I think it's probably better to upgrade your yacc.  I guess we could add 
a configure test for this and disable msi.dll if yacc is not new enough, 
but I'm hesitant to remove %pure-parser because msi.dll will require a 
second parser for parsing conditions in the database.  Additionally, I 
don't like the idea of adding a critical section to that code.

Mike


Stefan Leichter wrote:
> Hello,
>
> i can not compile msi.dll on one of my systems. make aborts with:
>
> yacc -d -t ../../../wine/dlls/msi/sql.y
> yacc: e - line 69 of "../../../wine/dlls/msi/sql.y", syntax error
> %pure-parser
> ^
> make[2]: *** [y.tab.c] Error 1
> make[2]: Leaving directory `/usr/src/wine-build/dlls/msi'
> make[1]: *** [msi] Error 2
> make[1]: Leaving directory `/usr/src/wine-build/dlls'
> make: *** [dlls] Error 2
>
> The second system compiles fine. It uses bison instead of yacc.
>
> Both systems are SuSE 7.3
> > rpm -qa | grep -e bison -e yacc
>
> yacc-91.7.30-379
> bison-1.28-127
>
> I know i can install bison and it will compile, but i think this needs to be 
> fixed.
>
> Bye Stefan

[Todd Vierling]

On Sun, 31 Aug 2003, Mike McCormack wrote:

: I think it's probably better to upgrade your yacc.  I guess we could add
: a configure test for this and disable msi.dll if yacc is not new enough,

Currently configure.ac is already checking for yacc vs. bison (search for
XYACC), but does nothing with that value.  It probably should check only for
bison, and abort on error if it is not found.

Alternatively, bison can be manually run on the .y and the resultant y.tab
can be checked in to CVS.

-- 
-- Todd Vierling <tv(a)pobox.com>

[Mike McCormack]

Hi Todd,

I think we should make configure check whether %pure-parser is 
supported, rather than presuming that yacc doesn't support it and bison 
does.

Mike


Todd Vierling wrote:
> Currently configure.ac is already checking for yacc vs. bison (search for
> XYACC), but does nothing with that value.  It probably should check only for
> bison, and abort on error if it is not found.