Re: remove the --managed option
--- "Dimitrie O. Paun" <dpaun(a)rogers.com> wrote:
As promised long ago :) I was away for a little while.
ChangeLog: Remove the --managed option, and make wine use the managed mode by default.
hmm, I don't personally see any benefit in this, I have my wine setup to use managed on some things, but unmanaged on others... Also, if this does (or has already) been committed, did you take care of the Managed option in the wine config? -Dustin __________________________________________________ Do You Yahoo!? LAUNCH - Your Yahoo! Music Experience http://launch.yahoo.com
On May 22, 2002 02:54 pm, Dustin Navea wrote:
--- "Dimitrie O. Paun" <dpaun(a)rogers.com> wrote:
As promised long ago :) I was away for a little while.
ChangeLog: Remove the --managed option, and make wine use the managed mode by default.
hmm, I don't personally see any benefit in this, I have my wine setup to use managed on some things, but unmanaged on others...
As Alexandre was saying, it was on its way out anyway, for many reasons. Read his email.
Also, if this does (or has already) been committed, did you take care of the Managed option in the wine config?
No, I have not seen it there. I looked for it in winedefault.reg, but could not find it there... -- Dimi.
Hi, Is this in current CVS? I'm still getting occasional Wine managed (or at least Wine decorated) windows with Managed=Y in .wine/config -- degs On Thursday 23 May 2002 05:52, Dimitrie O. Paun wrote:
On May 22, 2002 02:54 pm, Dustin Navea wrote:
--- "Dimitrie O. Paun" <dpaun(a)rogers.com> wrote:
As promised long ago :) I was away for a little while.
ChangeLog: Remove the --managed option, and make wine use the managed mode by default.
hmm, I don't personally see any benefit in this, I have my wine setup to use managed on some things, but unmanaged on others...
As Alexandre was saying, it was on its way out anyway, for many reasons. Read his email.
Also, if this does (or has already) been committed, did you take care of the Managed option in the wine config?
No, I have not seen it there. I looked for it in winedefault.reg, but could not find it there...
Should I expect to see any non-MDI Wine decorated windows if I have Managed=Y set in .wine/config? I'm using CVS as of about two hours ago. -- degs On Thursday 23 May 2002 15:46, Dimitrie O. Paun wrote:
On May 23, 2002 10:37 am, degs wrote:
Hi,
Is this in current CVS? I'm still getting occasional Wine managed (or at least Wine decorated) windows with Managed=Y in .wine/config
Yes, since last night.
On May 23, 2002 10:56 am, degs wrote:
Should I expect to see any non-MDI Wine decorated windows if I have Managed=Y set in .wine/config? I'm using CVS as of about two hours ago.
There is no mention of "Managed" in the current source base, hence the flag will be ignored. What you're seeing is something else. More exactly, this is what determines if a window will be managed by your window manager: (from ./dlls/x11drv/window.c) BOOL managed = is_top_level && is_window_managed( win ); where: inline static BOOL is_window_managed( WND *win ) { /* tray window is always managed */ if (win->dwExStyle & WS_EX_TRAYWINDOW) return TRUE; /* child windows are not managed */ if (win->dwStyle & WS_CHILD) return FALSE; /* tool windows are not managed */ if (win->dwExStyle & WS_EX_TOOLWINDOW) return FALSE; /* windows with caption or thick frame are managed */ if ((win->dwStyle & WS_CAPTION) == WS_CAPTION) return TRUE; if (win->dwStyle & WS_THICKFRAME) return TRUE; /* default: not managed */ return FALSE; } In other words, *only* top level windows that are tray windows, or have captions, or have thick frames are managed by the window manager (simplified explanation, the code above tells you _exactly_ what is going on :))) ). All others are handled by Wine. -- Dimi.
Ahhh - I'd got as far as this bit of code but for some reason I convinced myself that there must be more to it than that and I carried on looking :-) Thanks -- degs On Thursday 23 May 2002 16:51, Dimitrie O. Paun wrote:
On May 23, 2002 10:56 am, degs wrote:
Should I expect to see any non-MDI Wine decorated windows if I have Managed=Y set in .wine/config? I'm using CVS as of about two hours ago.
There is no mention of "Managed" in the current source base, hence the flag will be ignored. What you're seeing is something else. More exactly, this is what determines if a window will be managed by your window manager: (from ./dlls/x11drv/window.c)
BOOL managed = is_top_level && is_window_managed( win );
where:
inline static BOOL is_window_managed( WND *win ) { /* tray window is always managed */ if (win->dwExStyle & WS_EX_TRAYWINDOW) return TRUE; /* child windows are not managed */ if (win->dwStyle & WS_CHILD) return FALSE; /* tool windows are not managed */ if (win->dwExStyle & WS_EX_TOOLWINDOW) return FALSE; /* windows with caption or thick frame are managed */ if ((win->dwStyle & WS_CAPTION) == WS_CAPTION) return TRUE; if (win->dwStyle & WS_THICKFRAME) return TRUE; /* default: not managed */ return FALSE; }
In other words, *only* top level windows that are tray windows, or have captions, or have thick frames are managed by the window manager (simplified explanation, the code above tells you _exactly_ what is going on :))) ). All others are handled by Wine.
--- "Dimitrie O. Paun" <dpaun(a)rogers.com> wrote:
No, I have not seen it there. I looked for it in winedefault.reg, but could not find it there...
check ~/.wine/config... if we are going to remove the --managed argument, we should remove any traces of being able to be unmanaged... __________________________________________________ Do You Yahoo!? LAUNCH - Your Yahoo! Music Experience http://launch.yahoo.com
On Thu, 23 May 2002, Dustin Navea wrote:
--- "Dimitrie O. Paun" <dpaun(a)rogers.com> wrote:
No, I have not seen it there. I looked for it in winedefault.reg, but could not find it there...
check ~/.wine/config... if we are going to remove the --managed argument, we should remove any traces of being able to be unmanaged...
Why? My understanding was that we would just do it from the config file rather than from the command line. But AFAIU the capability is still there. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Hiroshima '45 - Czernobyl '86 - Windows '95
--- Francois Gouget <fgouget(a)free.fr> wrote:
On Thu, 23 May 2002, Dustin Navea wrote:
--- "Dimitrie O. Paun" <dpaun(a)rogers.com> wrote:
No, I have not seen it there. I looked for it in winedefault.reg, but could not find it there...
check ~/.wine/config... if we are going to remove the --managed argument, we should remove any traces of being able to be unmanaged...
Why? My understanding was that we would just do it from the config file rather than from the command line. But AFAIU the capability is still there.
That email was sent before I read the one about being able to do it from the config... please ignore it... __________________________________________________ Do You Yahoo!? LAUNCH - Your Yahoo! Music Experience http://launch.yahoo.com
--- Francois Gouget <fgouget(a)free.fr> wrote:
On Thu, 23 May 2002, Dustin Navea wrote:
--- "Dimitrie O. Paun" <dpaun(a)rogers.com> wrote:
No, I have not seen it there. I looked for it in winedefault.reg, but could not find it there...
check ~/.wine/config... if we are going to remove the --managed argument, we should remove any traces of being able to be unmanaged...
Why? My understanding was that we would just do it from the config file rather than from the command line. But AFAIU the capability is still there.
That email was sent before I read the one about being able to do it from the config... please ignore it... __________________________________________________ Do You Yahoo!? LAUNCH - Your Yahoo! Music Experience http://launch.yahoo.com
Dustin Navea wrote:
--- "Dimitrie O. Paun" <dpaun(a)rogers.com> wrote:
No, I have not seen it there. I looked for it in winedefault.reg, but could not find it there...
check ~/.wine/config... if we are going to remove the --managed argument, we should remove any traces of being able to be unmanaged...
And the docu.... If we remove the functionality we need to change the documentation as well. Do we have a bug report on this at least. If not I can start one. Tony Lambregts
--- Tony Lambregts <tony_lambregts(a)telusplanet.net> wrote:
Dustin Navea wrote:
--- "Dimitrie O. Paun" <dpaun(a)rogers.com> wrote:
No, I have not seen it there. I looked for it in winedefault.reg, but could not find it there...
check ~/.wine/config... if we are going to remove the --managed argument, we should remove any traces of being able to be unmanaged...
And the docu.... If we remove the functionality we need to change the documentation as well.
Do we have a bug report on this at least. If not I can start one.
Tony Lambregts
Actually, Alexandre decided to keep the Managed config option in, and with good reason... so we just need to update the docs to reflect that they can only use the Managed config option now. There isn't a bug report, so if one does need to be created, yea go ahead... __________________________________________________ Do You Yahoo!? LAUNCH - Your Yahoo! Music Experience http://launch.yahoo.com
Dustin Navea wrote:
Actually, Alexandre decided to keep the Managed config option in, and with good reason... so we just need to update the docs to reflect that they can only use the Managed config option now. There isn't a bug report, so if one does need to be created, yea go ahead...
I added a comment to http://bugs.winehq.com/show_bug.cgi?id=84 It seemed more appropriate than starting a new bug. Tony Lambregts
participants (5)
-
degs -
Dimitrie O. Paun -
Dustin Navea -
Francois Gouget -
Tony Lambregts