[v2 PATCH] d3d11: Fix freed memory access when releasing device context (Coverity).

[Nikolay Sivov]

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>
---
 dlls/d3d11/device.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dlls/d3d11/device.c b/dlls/d3d11/device.c
index d3e49879676..56f34c70ea1 100644
--- a/dlls/d3d11/device.c
+++ b/dlls/d3d11/device.c
@@ -521,13 +521,14 @@ static ULONG STDMETHODCALLTYPE d3d11_device_context_Release(ID3D11DeviceContext1
 
     if (!refcount)
     {
+        ID3D11Device2 *device = &context->device->ID3D11Device2_iface;
         if (context->type != D3D11_DEVICE_CONTEXT_IMMEDIATE)
         {
             wined3d_deferred_context_destroy(context->wined3d_context);
             d3d11_device_context_cleanup(context);
             heap_free(context);
         }
-        ID3D11Device2_Release(&context->device->ID3D11Device2_iface);
+        ID3D11Device2_Release(device);
     }
 
     return refcount;
-- 
2.30.2

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=92109

Your paranoid android.


=== debiant2 (32 bit report) ===

d3d11:
d3d11.c:9766: Test failed: d3d11.c:15246: Test marked todo: Got hr 0 for WRITE_DISCARD.

=== debiant2 (32 bit Chinese:China report) ===

d3d11:
d3d11.c:16624: Test failed: d3d11.c:16407: Test marked todo: Got 0xdeadbeef, expected 0xff000000 or 0xff000000 at 0, uvec4 0, 0, 0, 0xffffffff.

[Henri Verbeet]

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>