Re: [PATCH 5/9] cmd/tests: fix TODOs in test output (quotes)

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=14398

Your paranoid android.


=== WNT4WSSP6 (32 bit) ===
batch.c:298: Test failed: excess characters on line 17 (got 'error 1', wanted '')
batch.c:295: Test failed: unexpected end of line 18 (got '', wanted '>call say "one" ')
batch.c:301: Test failed: unexpected char 0x3e position 0 in line 19 (got '>call say "one" ', wanted '0(a)space@')
batch.c:298: Test failed: excess characters on line 20 (got '0 ', wanted '')
batch.c:295: Test failed: unexpected end of line 21 (got '', wanted '>call s"ay one ')
batch.c:301: Test failed: unexpected char 0x3e position 0 in line 22 (got '>call s"ay one ', wanted '1(a)space@')
batch.c:298: Test failed: excess characters on line 23 (got '1 ', wanted '')
batch.c:301: Test failed: unexpected char 0x65 position 0 in line 24 (got 'error 1', wanted '>call s"aytwo ')
batch.c:295: Test failed: unexpected end of line 25 (got '', wanted '2(a)space@')
batch.c:298: Test failed: excess characters on line 26 (got '>call s"aytwo ', wanted '')
batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '>call say (3) ')
batch.c:301: Test failed: unexpected char 0x65 position 0 in line 28 (got 'error 1', wanted '0(a)space@')
batch.c:301: Test failed: unexpected char 0x3e position 0 in line 30 (got '>call say (3) ', wanted '>call "say (3)" ')
batch.c:301: Test failed: unexpected char 0x30 position 0 in line 31 (got '0 ', wanted '3(a)space@')
batch.c:301: Test failed: unexpected char 0x3e position 0 in line 33 (got '>call "say (3)" ', wanted '>call say" (3)" ')
batch.c:301: Test failed: unexpected char 0x3e position 0 in line 36 (got '>call say" (3)" ', wanted '>call say" "(3) prints 4?! ')
batch.c:301: Test failed: unexpected char 0x33 position 0 in line 37 (got '3 ', wanted '4(a)space@')
batch.c:301: Test failed: unexpected char 0x65 position 0 in line 38 (got 'error 1', wanted '------ Testing invocation with CMD /C -------------')
batch.c:301: Test failed: unexpected char 0x3e position 0 in line 40 (got '>call say" "(3) prints 4?! ', wanted '>cmd /c say one ')
batch.c:301: Test failed: unexpected char 0x34 position 0 in line 41 (got '4 ', wanted '0(a)space@')
batch.c:298: Test failed: excess characters on line 42 (got 'error 1', wanted '')
batch.c:301: Test failed: unexpected char 0x2d position 0 in line 43 (got '------ Testing invocation with CMD /C -------------', wanted '>cmd /c "say one" ')
batch.c:295: Test failed: unexpected end of line 44 (got '', wanted '1(a)space@')
batch.c:298: Test failed: excess characters on line 45 (got '>cmd /c say one ', wanted '')
batch.c:301: Test failed: unexpected char 0x30 position 0 in line 46 (got '0 ', wanted '>cmd /c "say"" one" ')
batch.c:295: Test failed: unexpected end of line 47 (got '', wanted '0(a)space@')
batch.c:298: Test failed: excess characters on line 48 (got '>cmd /c "say one" ', wanted '')
batch.c:301: Test failed: unexpected char 0x31 position 0 in line 49 (got '1 ', wanted '>cmd /c "say one ')
batch.c:295: Test failed: unexpected end of line 50 (got '', wanted '0(a)space@')
batch.c:298: Test failed: excess characters on line 51 (got '>cmd /c "say"" one" ', wanted '')
batch.c:301: Test failed: unexpected char 0x30 position 0 in line 52 (got '0 ', wanted '>cmd /c say" one" ')
batch.c:295: Test failed: unexpected end of line 53 (got '', wanted '1(a)space@')
batch.c:298: Test failed: excess characters on line 54 (got '>cmd /c "say one ', wanted '')
batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '>cmd /c say "one" ')
batch.c:295: Test failed: unexpected end of line 56 (got '', wanted '0(a)space@')
batch.c:298: Test failed: excess characters on line 57 (got '>cmd /c say" one" ', wanted '')
batch.c:301: Test failed: unexpected char 0x31 position 0 in line 58 (got '1 ', wanted '>cmd /c s"ay one ')
batch.c:295: Test failed: unexpected end of line 59 (got '', wanted '1(a)space@')
batch.c:298: Test failed: excess characters on line 60 (got '>cmd /c say "one" ', wanted '')
batch.c:301: Test failed: unexpected char 0x30 position 0 in line 61 (got '0 ', wanted '>cmd /c s"aytwo ')
batch.c:295: Test failed: unexpected end of line 62 (got '', wanted '2(a)space@')
batch.c:298: Test failed: excess characters on line 63 (got '>cmd /c s"ay one ', wanted '')
batch.c:301: Test failed: unexpected char 0x31 position 0 in line 64 (got '1 ', wanted '>cmd /c say (3) ')
batch.c:295: Test failed: unexpected end of line 65 (got '', wanted '0(a)space@')
batch.c:298: Test failed: excess characters on line 66 (got '>cmd /c s"aytwo ', wanted '')
batch.c:301: Test failed: unexpected char 0x32 position 0 in line 67 (got '2 ', wanted '>cmd /c say" (3)" ')
batch.c:295: Test failed: unexpected end of line 68 (got '', wanted '3(a)space@')
batch.c:298: Test failed: excess characters on line 69 (got '>cmd /c say (3) ', wanted '')
batch.c:301: Test failed: unexpected char 0x30 position 0 in line 70 (got '0 ', wanted '>cmd /c say" "(3) prints 4?! ')
batch.c:295: Test failed: unexpected end of line 71 (got '', wanted '4(a)space@')
batch.c:301: Test failed: unexpected char 0x3e position 0 in line 72 (got '>cmd /c say" (3)" ', wanted '---------- Testing CMD /C quoting -----------------')
batch.c:298: Test failed: excess characters on line 73 (got '3 ', wanted '')
batch.c:295: Test failed: unexpected end of line 74 (got '', wanted '>cmd /c @echo "hi" ')
batch.c:301: Test failed: unexpected char 0x3e position 0 in line 75 (got '>cmd /c say" "(3) prints 4?! ', wanted '"hi"')
batch.c:298: Test failed: excess characters on line 76 (got '4 ', wanted '')
batch.c:301: Test failed: unexpected char 0x2d position 0 in line 77 (got '---------- Testing CMD /C quoting -----------------', wanted '>cmd /c say" "one ')
batch.c:295: Test failed: unexpected end of line 78 (got '', wanted '1(a)space@')
batch.c:298: Test failed: excess characters on line 79 (got '>cmd /c @echo "hi" ', wanted '')
batch.c:301: Test failed: unexpected char 0x22 position 0 in line 80 (got '"hi"', wanted '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ')
batch.c:295: Test failed: unexpected end of line 81 (got '', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"')
batch.c:298: Test failed: excess characters on line 82 (got '>cmd /c say" "one ', wanted '')
batch.c:301: Test failed: unexpected char 0x31 position 0 in line 83 (got '1 ', wanted '>cmd /c "say one" ')
batch.c:295: Test failed: unexpected end of line 84 (got '', wanted '1(a)space@')
batch.c:298: Test failed: excess characters on line 85 (got '>cmd /c @echo "\"\\"\\\"\\\\" "\"\\"\\\"\\\\" ', wanted '')
batch.c:301: Test failed: unexpected char 0x22 position 0 in line 86 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '>cmd /s/c "say one" ')
batch.c:295: Test failed: unexpected end of line 87 (got '', wanted '0(a)space@')
batch.c:298: Test failed: excess characters on line 88 (got '>cmd /c "say one" ', wanted '')
batch.c:301: Test failed: unexpected char 0x31 position 0 in line 89 (got '1 ', wanted '>cmd /s/c ""say one"" ')
batch.c:295: Test failed: unexpected end of line 90 (got '', wanted '1(a)space@')
batch.c:298: Test failed: excess characters on line 91 (got '>cmd /s/c "say one" ', wanted '')
batch.c:301: Test failed: unexpected char 0x30 position 0 in line 92 (got '0 ', wanted '>cmd /c "say one ')
batch.c:295: Test failed: unexpected end of line 93 (got '', wanted '0(a)space@')
batch.c:298: Test failed: excess characters on line 94 (got '>cmd /s/c ""say one"" ', wanted '')
batch.c:301: Test failed: unexpected char 0x31 position 0 in line 95 (got '1 ', wanted '>cmd /c "say"" one" ')
batch.c:295: Test failed: unexpected end of line 96 (got '', wanted '0(a)space@')
batch.c:298: Test failed: excess characters on line 97 (got '>cmd /c "say one ', wanted '')
batch.c:301: Test failed: unexpected char 0x30 position 0 in line 98 (got '0 ', wanted '>cmd /c "say (3)" ')
batch.c:295: Test failed: unexpected end of line 99 (got '', wanted '0(a)space@@or_broken(a)3@space@')
batch.c:298: Test failed: excess characters on line 100 (got '>cmd /c "say"" one" ', wanted '')
batch.c:301: Test failed: unexpected char 0x30 position 0 in line 101 (got '0 ', wanted '>cmd /c ""say (3)"" ')
batch.c:295: Test failed: unexpected end of line 102 (got '', wanted '3(a)space@')
batch.c:298: Test failed: excess characters on line 103 (got '>cmd /c "say (3)" ', wanted '')
batch.c:301: Test failed: unexpected char 0x30 position 0 in line 104 (got '0 ', wanted '>cmd /c saytwo ')
batch.c:295: Test failed: unexpected end of line 105 (got '', wanted '2(a)space@')
batch.c:298: Test failed: excess characters on line 106 (got '>cmd /c ""say (3)"" ', wanted '')
batch.c:301: Test failed: unexpected char 0x33 position 0 in line 107 (got '3 ', wanted '>cmd /c "saytwo" ')
batch.c:295: Test failed: unexpected end of line 108 (got '', wanted '2(a)space@')
batch.c:298: Test failed: excess characters on line 109 (got '>cmd /c saytwo ', wanted '')
batch.c:301: Test failed: unexpected char 0x32 position 0 in line 110 (got '2 ', wanted '>cmd /c "saytwo ')
batch.c:295: Test failed: unexpected end of line 111 (got '', wanted '2(a)space@')
batch.c:298: Test failed: excess characters on line 112 (got '>cmd /c "saytwo" ', wanted '')
batch.c:301: Test failed: unexpected char 0x32 position 0 in line 113 (got '2 ', wanted '>cmd /c "say five" ')
batch.c:295: Test failed: unexpected end of line 114 (got '', wanted '0(a)space@')
batch.c:298: Test failed: excess characters on line 115 (got '>cmd /c "saytwo ', wanted '')
batch.c:301: Test failed: unexpected char 0x32 position 0 in line 116 (got '2 ', wanted '>cmd /c "say five" ')
batch.c:295: Test failed: unexpected end of line 117 (got '', wanted '5(a)space@')
batch.c:301: Test failed: unexpected char 0x3e position 0 in line 118 (got '>cmd /c "say five" ', wanted '------- Testing CMD /C qualifier treatment ------------')
batch.c:298: Test failed: excess characters on line 119 (got '0 ', wanted '')
batch.c:295: Test failed: unexpected end of line 120 (got '', wanted '>cmd /csay one ')
batch.c:301: Test failed: unexpected char 0x3e position 0 in line 121 (got '>cmd /c "say five" ', wanted '0(a)space@')
batch.c:298: Test failed: excess characters on line 122 (got '5 ', wanted '')
batch.c:301: Test failed: unexpected char 0x2d position 0 in line 123 (got '------- Testing CMD /C qualifier treatment ------------', wanted '>cmd /c"say one" ')
batch.c:295: Test failed: unexpected end of line 124 (got '', wanted '1(a)space@')
batch.c:298: Test failed: excess characters on line 125 (got '>cmd /csay one ', wanted '')
batch.c:301: Test failed: unexpected char 0x30 position 0 in line 126 (got '0 ', wanted '>cmd "/c"say one ')
batch.c:295: Test failed: unexpected end of line 127 (got '', wanted '0(a)space@')
batch.c:298: Test failed: excess characters on line 128 (got '>cmd /c"say one" ', wanted '')
batch.c:301: Test failed: unexpected char 0x31 position 0 in line 129 (got '1 ', wanted '>cmd ignoreme/c say one ')
batch.c:295: Test failed: unexpected end of line 130 (got '', wanted '0(a)space@')
batch.c:301: Test failed: unexpected char 0x3e position 0 in line 131 (got '>cmd "/c"say one ', wanted '--------- Testing special characters --------------')
batch.c:298: Test failed: excess characters on line 132 (got '0 ', wanted '')
batch.c:295: Test failed: unexpected end of line 133 (got '', wanted '>call say ')
batch.c:301: Test failed: unexpected char 0x3e position 0 in line 134 (got '>cmd ignoreme/c say one ', wanted '0(a)space@')
batch.c:298: Test failed: excess characters on line 135 (got '0 ', wanted '')
batch.c:301: Test failed: unexpected char 0x2d position 0 in line 136 (got '--------- Testing special characters --------------', wanted '>call say( ')
batch.c:295: Test failed: unexpected end of line 137 (got '', wanted '0(a)space@')
batch.c:298: Test failed: excess characters on line 138 (got '>call say ', wanted '')
batch.c:301: Test failed: unexpected char 0x30 position 0 in line 139 (got '0 ', wanted '>call say) ')
batch.c:295: Test failed: unexpected end of line 140 (got '', wanted ')@space@')
batch.c:298: Test failed: excess characters on line 141 (got '>call say( ', wanted '')
batch.c:301: Test failed: unexpected char 0x30 position 0 in line 142 (got '0 ', wanted '>call say[ ')
batch.c:295: Test failed: unexpected end of line 143 (got '', wanted '[@space@')
batch.c:298: Test failed: excess characters on line 144 (got '>call say) ', wanted '')
batch.c:301: Test failed: unexpected char 0x29 position 0 in line 145 (got ') ', wanted '>call say] ')
batch.c:295: Test failed: unexpected end of line 146 (got '', wanted ']@space@')
batch.c:298: Test failed: excess characters on line 147 (got '>call say[ ', wanted '')
batch.c:301: Test failed: unexpected char 0x5b position 0 in line 148 (got '[ ', wanted '>call say{ ')
batch.c:295: Test failed: unexpected end of line 149 (got '', wanted '{@space@')
batch.c:298: Test failed: excess characters on line 150 (got '>call say] ', wanted '')
batch.c:301: Test failed: unexpected char 0x5d position 0 in line 151 (got '] ', wanted '>call say} ')
batch.c:295: Test failed: unexpected end of line 152 (got '', wanted '}@space@')
batch.c:298: Test failed: excess characters on line 153 (got '>call say{ ', wanted '')
batch.c:301: Test failed: unexpected char 0x7b position 0 in line 154 (got '{ ', wanted '>call say= ')
batch.c:295: Test failed: unexpected end of line 155 (got '', wanted '0(a)space@')
batch.c:298: Test failed: excess characters on line 156 (got '>call say} ', wanted '')
batch.c:301: Test failed: unexpected char 0x7d position 0 in line 157 (got '} ', wanted '>call say; ')
batch.c:295: Test failed: unexpected end of line 158 (got '', wanted '0(a)space@')
batch.c:298: Test failed: excess characters on line 159 (got '>call say= ', wanted '')
batch.c:301: Test failed: unexpected char 0x30 position 0 in line 160 (got '0 ', wanted '>call say! ')
batch.c:295: Test failed: unexpected end of line 161 (got '', wanted '!@space@')
batch.c:298: Test failed: excess characters on line 162 (got '>call say; ', wanted '')
batch.c:301: Test failed: unexpected char 0x30 position 0 in line 163 (got '0 ', wanted '>call say! ')
batch.c:295: Test failed: unexpected end of line 164 (got '', wanted '0(a)space@')
batch.c:298: Test failed: excess characters on line 165 (got '>call say! ', wanted '')
batch.c:301: Test failed: unexpected char 0x21 position 0 in line 166 (got '! ', wanted '>call say% ')
batch.c:295: Test failed: unexpected end of line 167 (got '', wanted '0(a)space@')
batch.c:298: Test failed: excess characters on line 168 (got '>call say! ', wanted '')
batch.c:301: Test failed: unexpected char 0x21 position 0 in line 169 (got '! ', wanted '>call say' ')
batch.c:295: Test failed: unexpected end of line 170 (got '', wanted ''@space@')
batch.c:298: Test failed: excess characters on line 171 (got '>call say% ', wanted '')
batch.c:301: Test failed: unexpected char 0x30 position 0 in line 172 (got '0 ', wanted '>call say+ ')
batch.c:295: Test failed: unexpected end of line 173 (got '', wanted '+(a)space@')
batch.c:298: Test failed: excess characters on line 174 (got '>call say' ', wanted '')
batch.c:301: Test failed: unexpected char 0x27 position 0 in line 175 (got '' ', wanted '>call say, ')
batch.c:295: Test failed: unexpected end of line 176 (got '', wanted '0(a)space@')
batch.c:298: Test failed: excess characters on line 177 (got '>call say+ ', wanted '')
batch.c:301: Test failed: unexpected char 0x2b position 0 in line 178 (got '+ ', wanted '>call say' ')
batch.c:295: Test failed: unexpected end of line 179 (got '', wanted ''@space@')
batch.c:298: Test failed: excess characters on line 180 (got '>call say, ', wanted '')
batch.c:301: Test failed: unexpected char 0x30 position 0 in line 181 (got '0 ', wanted '>call say~ ')
batch.c:295: Test failed: unexpected end of line 182 (got '', wanted '~@space@')
batch.c:301: Test failed: unexpected char 0x3e position 0 in line 183 (got '>call say' ', wanted '--------- Testing parameter passing  --------------')
batch.c:298: Test failed: excess characters on line 184 (got '' ', wanted '')
batch.c:295: Test failed: unexpected end of line 185 (got '', wanted '>call tell 1 ')
batch.c:301: Test failed: unexpected char 0x3e position 0 in line 186 (got '>call say~ ', wanted '1:1,2:@space@')
batch.c:298: Test failed: excess characters on line 187 (got '~ ', wanted '')
batch.c:301: Test failed: unexpected char 0x2d position 0 in line 188 (got '--------- Testing parameter passing  --------------', wanted '>call tell (1) ')
batch.c:295: Test failed: unexpected end of line 189 (got '', wanted '1:(1),2:@space@')
batch.c:298: Test failed: excess characters on line 190 (got '>call tell 1 ', wanted '')
batch.c:301: Test failed: unexpected char 0x31 position 0 in line 191 (got '1:1,2: ', wanted '>call tell 1(2) ')
batch.c:295: Test failed: unexpected end of line 192 (got '', wanted '1:1(2),2:@space@')
batch.c:298: Test failed: excess characters on line 193 (got '>call tell (1) ', wanted '')
batch.c:301: Test failed: unexpected char 0x31 position 0 in line 194 (got '1:(1),2: ', wanted '>call tell(1) ')
batch.c:295: Test failed: unexpected end of line 195 (got '', wanted '1:(1),2:@space@')
batch.c:298: Test failed: excess characters on line 196 (got '>call tell 1(2) ', wanted '')
batch.c:301: Test failed: unexpected char 0x31 position 0 in line 197 (got '1:1(2),2: ', wanted '>call tell((1)) ')
batch.c:295: Test failed: unexpected end of line 198 (got '', wanted '1:((1)),2:@space@')
batch.c:298: Test failed: excess characters on line 199 (got '>call tell(1) ', wanted '')
batch.c:301: Test failed: unexpected char 0x31 position 0 in line 200 (got '1:(1),2: ', wanted '>call tell(1)(2) ')
batch.c:301: Test failed: unexpected char 0x65 position 0 in line 201 (got 'error 1', wanted '1:(1)(2),2:@space@')
batch.c:301: Test failed: unexpected char 0x3e position 0 in line 203 (got '>call tell((1)) ', wanted '>call tell(1);,;(2) ')
batch.c:301: Test failed: unexpected char 0x31 position 0 in line 204 (got '1:((1)),2: ', wanted '1:(1),2:(2)@space@')
batch.c:298: Test failed: excess characters on line 205 (got 'error 1', wanted '')
batch.c:295: Test failed: unexpected end of line 206 (got '', wanted '>call tell;1 2 ')
batch.c:301: Test failed: unexpected char 0x3e position 0 in line 207 (got '>call tell(1)(2) ', wanted '1:1,2:2(a)space@')
batch.c:298: Test failed: excess characters on line 208 (got '1:(1)(2),2: ', wanted '')
batch.c:301: Test failed: unexpected char 0x65 position 0 in line 209 (got 'error 1', wanted '>call tell; 1, ;2 ')
batch.c:295: Test failed: unexpected end of line 210 (got '', wanted '1:1,2:2(a)space@')
batch.c:298: Test failed: excess characters on line 211 (got '>call tell(1);,;(2) ', wanted '')
batch.c:301: Test failed: unexpected char 0x31 position 0 in line 212 (got '1:(1),2:(2) ', wanted '>call tell;1;;2 ')
batch.c:301: Test failed: unexpected char 0x65 position 0 in line 213 (got 'error 1', wanted '1:1,2:2(a)space@')
batch.c:301: Test failed: unexpected char 0x3e position 0 in line 215 (got '>call tell;1 2 ', wanted '>call tell "p "1 p" "2 ')
batch.c:301: Test failed: unexpected char 0x31 position 0 in line 216 (got '1:1,2:2 ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@')
batch.c:298: Test failed: excess characters on line 217 (got 'error 1', wanted '')
batch.c:295: Test failed: unexpected end of line 218 (got '', wanted '>call tell p"1 p";2 ')
batch.c:301: Test failed: unexpected char 0x3e position 0 in line 219 (got '>call tell; 1, ;2 ', wanted '1:p"1(a)space@p",2:2(a)space@')
batch.c:315: Test failed: too long output, got additional 1:1,2:2