Re: [PATCH 2/3] wined3d: Add NV/ARB_texture_rectangle extension (try 2)
Am Donnerstag 29 März 2007 17:13 schrieb Vitaly Budovski:
Add support for NV_texture_rectangle and ARB_texture_rectangle extensions. --- dlls/wined3d/directx.c | 6 ++++++ include/wine/wined3d_gl.h | 19 +++++++++++++++++++ 2 files changed, 25 insertions(+), 0 deletions(-) Nothing really wrong with this patch, though I am concerned about patch 3. This patch is a dependency of patch 3, but there is nothing really wrong with adding the extensions.
On 29/03/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
Am Donnerstag 29 März 2007 17:13 schrieb Vitaly Budovski:
Add support for NV_texture_rectangle and ARB_texture_rectangle extensions. --- dlls/wined3d/directx.c | 6 ++++++ include/wine/wined3d_gl.h | 19 +++++++++++++++++++ 2 files changed, 25 insertions(+), 0 deletions(-) Nothing really wrong with this patch, Except that it adds an extension that isn't actually being used, and probably won't be.
Am Donnerstag 29 März 2007 17:31 schrieb H. Verbeet:
On 29/03/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
Am Donnerstag 29 März 2007 17:13 schrieb Vitaly Budovski:
Add support for NV_texture_rectangle and ARB_texture_rectangle extensions. --- dlls/wined3d/directx.c | 6 ++++++ include/wine/wined3d_gl.h | 19 +++++++++++++++++++ 2 files changed, 25 insertions(+), 0 deletions(-)
Nothing really wrong with this patch,
Except that it adds an extension that isn't actually being used, and probably won't be. Well, we have other extensions which are unused and are in our header files(or at least were unused for a long time, like NV_texture_shader). Wasn't there the plan to write our own gl headers with all the extensions out there?
On 29/03/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote:
Except that it adds an extension that isn't actually being used, and probably won't be. Well, we have other extensions which are unused and are in our header files(or at least were unused for a long time, like NV_texture_shader). Wasn't there the plan to write our own gl headers with all the extensions out there?
I think the plan was to add the definitions for base GL 1.1 or so, so we wouldn't have to deal with different GL headers. That would mostly make it easier for developers not to forget adding definitions when using extension. I don't think the idea was to just add everything out there, just the ones we use. Our wined3d_gl.h could use some cleanup, but at least NV_texture_shader is an extension we might end up using anyway for fixed function env. bump mapping.
participants (2)
-
H. Verbeet -
Stefan Dösinger