Re: CURSORICON_SimulateLoadingFromResourceW param check. VFP6 EXEs now work.

[Stefan Leichter]

Hello Uwe,

i fear your test will only test what you like to test if it is executed in the 
source directory. For "out of tree builds" your test case tests how 
LoadImageA behaves when the specified file does not exist.

Bye Stefan

Am Dienstag, 23. März 2004 21:29 schrieb Uwe Bonnes:
> > > > > > "C" == C Daniel Mojoli B <cdmojoli(a)idea.com.py> writes:
>
> C> Uwe Bonnes wrote:
>     >>>>>>> "C" == C Daniel Mojoli B <cdmojoli(a)idea.com.py> writes:
>
> C> Add minimal parameter validation to function
>     C> CURSORICON_SimulateLoadingFromResourceW(...). We check that the icon
>
> >> Providing a test case for such special behaviour is a good idea...
>
> C> I created this patch as a result of consulting I performed at a
>     C> customer's site. I no longer have access to the winedbg info I had
>
> It this what you meant?
>
> The test succeeds on NT and crashes on wine

CURSORICON_SimulateLoadingFromResourceW param check. VFP6 EXEs now work.

[Uwe Bonnes]

> > > > > "Stefan" == Stefan Leichter <Stefan.Leichter(a)camLine.com> writes:

Stefan> Hello Uwe, i fear your test will only test what you like to test
    Stefan> if it is executed in the source directory. For "out of tree
    Stefan> builds" your test case tests how LoadImageA behaves when the
    Stefan> specified file does not exist.

Any proposal for a better file to test?

-- 
Uwe Bonnes                bon(a)elektron.ikp.physik.tu-darmstadt.de

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. [phone] -------- Fax. [phone] ----------

CURSORICON_SimulateLoadingFromResourceW param check. VFP6 EXEs now work.

[Stefan Leichter]

Am Dienstag, 23. März 2004 23:39 schrieb Uwe Bonnes:
> > > > > > "Stefan" == Stefan Leichter <Stefan.Leichter(a)camLine.com> writes:
>
> Stefan> Hello Uwe, i fear your test will only test what you like to
> test Stefan> if it is executed in the source directory. For "out of tree
> Stefan> builds" your test case tests how LoadImageA behaves when the
> Stefan> specified file does not exist.
>
> Any proposal for a better file to test?

What about the test executable itself, maybe after copying it to a file with a 
different name?