Re: [PATCH 1/2] oleaut32/tests: Test return value of SysReAllocStringLen for the null terminator.

[Nikolay Sivov]

Alexander Kochetkov wrote:
> This test works fine under windows 98, XP and under wine.
> And allways check for the null terminator.
>
> see bug 20334.

Hi, Alexander.

You patches should not break test in order they are supposed to be 
applied: your test currently misses todo_wine here:
---

+        ok (str[STRING_SIZE] == 0, 
+            "Expected null terminator, got 0x%04X\n", str[STRING_SIZE]);
---

After that your second patch should remove this todo_wine marker.
Without such simple rule last patch (2/2) can't be reverted without breaking tests.

Another small issue is a trailing space in the same line

---

'ok (str[STRING_SIZE] == 0, '
---
it's not a big problem cause I believe patches are auto processed for such things before checking to tree,
it will lead to a merge conflict in your local repo, that's all.