Re: urlmon: Fix a test that fails on all platforms

[Dmitry Timoshkov]

"James Hawkins" <jhawkins(a)codeweavers.com> wrote:
> -        ok(IBindCtx_Release(bctx) == 0, "bctx should be destroyed here\n");
> +
> +        if(bindf & BINDF_ASYNCHRONOUS) {
> +            ok(IBindCtx_Release(bctx) == 1, "bctx should not be destroyed here\n");
> +            IBindCtx_Release(bctx); /* actually destroy it */
> +        }
> +        else
> +            ok(IBindCtx_Release(bctx) == 0, "bctx should be destroyed here\n");

Wouldn't it be better to change it this way:

if(bindf & BINDF_ASYNCHRONOUS)
    ok(IBindCtx_Release(bctx) == 1, "bctx should not be destroyed here\n");

ok(IBindCtx_Release(bctx) == 0, "bctx should be destroyed here\n");

-- 
Dmitry.

urlmon: Fix a test that fails on all platforms

[James Hawkins]

On Tue, Jun 3, 2008 at 8:52 PM, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote:
> "James Hawkins" <jhawkins(a)codeweavers.com> wrote:
> > -        ok(IBindCtx_Release(bctx) == 0, "bctx should be destroyed
> > here\n");
> > +
> > +        if(bindf & BINDF_ASYNCHRONOUS) {
> > +            ok(IBindCtx_Release(bctx) == 1, "bctx should not be destroyed
> > here\n");
> > +            IBindCtx_Release(bctx); /* actually destroy it */
> > +        }
> > +        else
> > +            ok(IBindCtx_Release(bctx) == 0, "bctx should be destroyed
> > here\n");
>
> Wouldn't it be better to change it this way:
>
> if(bindf & BINDF_ASYNCHRONOUS)
>   ok(IBindCtx_Release(bctx) == 1, "bctx should not be destroyed here\n");
>
> ok(IBindCtx_Release(bctx) == 0, "bctx should be destroyed here\n");

Yea that's simpler.  Unfortunately it crashes either way in wine.

-- 
James Hawkins