Re: [Toolbar] Fixes for IE Favourites 'menu'
This patch makes IE work beautifully. Its much better than with the native comctl32. It also uncovers another misbehaviour in our comctl32. IE crashes because TOOLTIPS_GetTipText isnt protected against NULL read attempts. 180 if (HIWORD((UINT)toolPtr->lpszText) == 0) { Wine-dbg>p toolPtr 0x00000000 Wine-dbg>list - 170 if (oldBkMode != TRANSPARENT) 171 SetBkMode (hdc, oldBkMode); 172 } 173 174 175 static VOID 176 TOOLTIPS_GetTipText (HWND hwnd, TOOLTIPS_INFO *infoPtr, INT nTool) 177 { 178 TTTOOL_INFO *toolPtr = &infoPtr->tools[nTool]; 179 180 if (HIWORD((UINT)toolPtr->lpszText) == 0) { Wine-dbg> Quick fix attached. ===== Sylvain Petreolle (spetreolle_at_users_dot_sourceforge_dot_net) ICQ #170597259 Say NO to software patents Dites NON aux brevets logiciels "What if tomorrow the War could be over ?" Morpheus, in "Reloaded". ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com
participants (1)
-
Sylvain Petreolle