Re: [PATCH 6/8] ddraw: Do not create implicit depth buffer.
2011/8/8 Ričardas Barkauskas <rbarkauskas(a)codeweavers.com>:
- localParameters.EnableAutoDepthStencil = TRUE; + localParameters.EnableAutoDepthStencil = FALSE; localParameters.AutoDepthStencilFormat = WINED3DFMT_D16_UNORM; As Stefan mentioned on IRC, you should probably set the format to 0 / WINED3DFMT_UNKNOWN. I wouldn't be opposed to zeroing localParameters and only initializing fields that should be non-zero either though. That would get rid of about half of the fields.
+ assert(FALSE); return D3D_OK; } Asserts don't do much on non-debug builds, so you probably want to at least return something like E_NOTIMPL. An ERR would probably be more descriptive than assert(FALSE), but it's probably mostly just personal preference.
participants (1)
-
Henri Verbeet