Compilation errors for Freetype support

[Andriy Palamarchuk]

Trying to compile today's Wine I get errors:

freetype.c: In function `WineEngGetGlyphOutline':
freetype.c:947: `FT_Angle' undeclared (first use in
this function)
freetype.c:947: (Each undeclared identifier is
reported only once
freetype.c:947: for each function it appears in.)
freetype.c:947: parse error before `angle'
freetype.c:993: `angle' undeclared (first use in this
function)
freetype.c:1003: warning: implicit declaration of
function `FT_Vector_Rotate'
freetype.c:1059: warning: implicit declaration of
function `FT_Cos'
freetype.c:1060: warning: implicit declaration of
function `FT_Sin'

Huw,
  these functions calls were introduced to the file by
your patch, applyed on Jan 29, 2002.

I believe the problems are because of differences
between freetype versions. The problem occurs on
freetype 2.0.1, but according to thread "Prob with
freetype..." is fixed after upgrading to 2.0.3.

Regards,
Andriy Palamarchuk

__________________________________________________
Do You Yahoo!?
Great stuff seeking new owners in Yahoo! Auctions! 
http://auctions.yahoo.com

[Bill Medland]

"Andriy Palamarchuk" <apa3a(a)yahoo.com> wrote in message
news:20020131142102.52659.qmail(a)web20206.mail.yahoo.com...
> Trying to compile today's Wine I get errors:
>
> freetype.c: In function `WineEngGetGlyphOutline':
> freetype.c:947: `FT_Angle' undeclared (first use in
> this function)
> freetype.c:947: (Each undeclared identifier is
> reported only once
> freetype.c:947: for each function it appears in.)
> freetype.c:947: parse error before `angle'
> freetype.c:993: `angle' undeclared (first use in this
> function)
> freetype.c:1003: warning: implicit declaration of
> function `FT_Vector_Rotate'
> freetype.c:1059: warning: implicit declaration of
> function `FT_Cos'
> freetype.c:1060: warning: implicit declaration of
> function `FT_Sin'
>
> Huw,
>   these functions calls were introduced to the file by
> your patch, applyed on Jan 29, 2002.
>
> I believe the problems are because of differences
> between freetype versions. The problem occurs on
> freetype 2.0.1, but according to thread "Prob with
> freetype..." is fixed after upgrading to 2.0.3.
>
> Regards,
> Andriy Palamarchuk
>
> __________________________________________________
> Do You Yahoo!?
> Great stuff seeking new owners in Yahoo! Auctions!
> http://auctions.yahoo.com

So what ought to be done in the code?
1. #else #error "This requires freetype 2.0.3 or later"
2. #else <Here are some definitions that will compile but assume an angle of
zero degrees> #endif
3. ifdefs around the use of FT_Angle etc to provide an alternative method of
achieving it or not supporting ot.

I am interested because I am still trying to get a feel for the typical
thinking in Linux development where there are more independent libraries and
they tend to change more frequently, adding support as they go.

Bill

[Marcus Meissner]

> So what ought to be done in the code?
> 1. #else #error "This requires freetype 2.0.3 or later"
> 2. #else <Here are some definitions that will compile but assume an angle of
> zero degrees> #endif
> 3. ifdefs around the use of FT_Angle etc to provide an alternative method of
> achieving it or not supporting ot.

Do autoconf checks for the presence of these functions.
If they can be implemented (or stubbed) easily, add a stub/implementation
between ifndefs.
If not, do not compile in the feature at all.

Ciao, Marcus

[Huw D M Davies]

On Thu, Jan 31, 2002 at 07:32:53AM -0800, Bill Medland wrote:
> So what ought to be done in the code?
> 1. #else #error "This requires freetype 2.0.3 or later"
> 2. #else <Here are some definitions that will compile but assume an angle of
> zero degrees> #endif
> 3. ifdefs around the use of FT_Angle etc to provide an alternative method of
> achieving it or not supporting ot.
>
> I am interested because I am still trying to get a feel for the typical
> thinking in Linux development where there are more independent libraries and
> they tend to change more frequently, adding support as they go.

Firstly sorry about the delay in replying to these problems; I've had
problems with my subscription to wine-devel, things seem to be back to
normal now though (thanks Andi!).

I'll add a configure test for the trig functions and disable FreeType
support if they're not present - there are other issues with 2.0.1
that make it unusable anyway.

If you're upgrading then go straight to 2.0.6 - there's a bug in
earlier versions that messes up inter-character spacing.

Huw.

[Huw D M Davies]

On Thu, Jan 31, 2002 at 04:34:02PM +0000, Huw D M Davies wrote:
> I'll add a configure test for the trig functions and disable FreeType
> support if they're not present - there are other issues with 2.0.1
> that make it unusable anyway.

How does this look?

Huw.

[Bill Medland]

"Huw D M Davies" <h.davies1(a)physics.ox.ac.uk> wrote in message
news:20020131171456.D16996(a)merlot.physics.ox.ac.uk...
> On Thu, Jan 31, 2002 at 04:34:02PM +0000, Huw D M Davies wrote:
> > I'll add a configure test for the trig functions and disable FreeType
> > support if they're not present - there are other issues with 2.0.1
> > that make it unusable anyway.
>
> How does this look?
>
> Huw.

Seems reasonable to me (but I count myself as a total newbie in all this
autoconf stuff)(Heck, I'm still a newbie in all this Linux stuff).

Bill