Re: Test case for Bug 50 [Was: Bug 50]

[Pedro Araujo Chaves Jr.]

I think I've managed to patch [1] bug 50 [2], but I'm having a little
trouble coming up with a proper test case...

I'm already at it, studying and investigating, but could someone test that,
too?

[1] http://bugs.winehq.org/attachment.cgi?id=4543&action=view
[2] http://bugs.winehq.org/show_bug.cgi?id=50

TIA,
- Pedro.

Test case for Bug 50 [Was: Bug 50]

[Pedro Araujo Chaves Jr.]

Update...

I thought I had managed to get Keith's idea and make up a patch, but,
to great grief -- and not so great a surprise --, I have just
discovered that my patch for bug 50 is not as effective on Lotus Notes
6.5.3 as it was in Notes R5 and the Petzold justify1 example.

Well, I'm checking some traces here, and noticed that version 6.5.3
uses a rather odd -- at least to me -- method for justifying a
paragraph... below is a section of the trace grepped to show only the
relevant calls. Here Notes is trying to justify the first paragraph of
a message, being the first line
> Lorem ipsum dolor sit amet, consectetuer adipiscing elit. Etiam tellus pede, semper id, convallis a, tincidunt ut, augue.

That's a single line -- or rather extent --, but here is what the log
says (ignore the excess of repetitions, I was trying to be thorough):

---- LOG SECTION STARTS HERE ----
trace:font:SetTextJustification (hdc=0xaa60, breakExtra=7, breakCount=7)
trace:font:GetTextExtentPoint32W (0xaa60 L"Lorem ipsum dolor sit amet,
consectetuer adipiscing elit" 56 0x34c1c4): returning 3457528 x 0
trace:font:GetTextExtentExPointW (0xaa60, L"Lorem ipsum dolor sit
amet, consectetuer adipiscing elit", 0)
trace:font:GetTextExtentExPointW hdc=0xaa60, cx=3457528, cy=0
trace:font:WineEngGetTextExtentExPoint 0x2de6e90, L"Lorem ipsum dolor
sit amet, consectetuer adipiscing elit", 56, 0, 0x34c1c4
trace:font:WineEngGetTextExtentExPoint return cx=333, cy=19, nfit=56
trace:font:GetTextExtentExPointW returning cx=333, cy=19, nFit=0
trace:font:SetTextJustification (hdc=0xaa60, breakExtra=0, breakCount=0)
trace:font:GetTextExtentPoint32W (0xaa60 L"." 1 0x34c1c4): returning 3457528 x 0
trace:font:GetTextExtentExPointW (0xaa60, L".", 0)
trace:font:GetTextExtentExPointW hdc=0xaa60, cx=3457528, cy=0
trace:font:WineEngGetTextExtentExPoint 0x2de6e90, L".", 1, 0, 0x34c1c4
trace:font:WineEngGetTextExtentExPoint return cx=4, cy=19, nfit=1
trace:font:GetTextExtentExPointW returning cx=4, cy=19, nFit=0
trace:font:SetTextJustification (hdc=0xaa60, breakExtra=1, breakCount=1)
trace:font:GetTextExtentPoint32W (0xaa60 L" " 1 0x34c1c4): returning 3457528 x 0
trace:font:GetTextExtentExPointW (0xaa60, L" ", 0)
trace:font:GetTextExtentExPointW hdc=0xaa60, cx=3457528, cy=0
trace:font:WineEngGetTextExtentExPoint 0x2de6e90, L" ", 1, 0, 0x34c1c4
trace:font:WineEngGetTextExtentExPoint return cx=4, cy=19, nfit=1
trace:font:GetTextExtentExPointW returning cx=4, cy=19, nFit=0
trace:font:SetTextJustification (hdc=0xaa60, breakExtra=0, breakCount=0)
trace:font:SetTextJustification (hdc=0xaa60, breakExtra=13, breakCount=9)
trace:font:GetTextExtentPoint32W (0xaa60 L"Etiam tellus pede, semper
id, convallis a, tincidunt ut, augue" 62 0x34c1c4): returning 3457528
x 0
trace:font:GetTextExtentExPointW (0xaa60, L"Etiam tellus pede, semper
id, convallis a, tincidunt ut, augue", 0)
trace:font:GetTextExtentExPointW hdc=0xaa60, cx=3457528, cy=0
trace:font:WineEngGetTextExtentExPoint 0x2de6e90, L"Etiam tellus pede,
semper id, convallis a, tincidunt ut, augue", 62, 0, 0x34c1c4
trace:font:WineEngGetTextExtentExPoint return cx=355, cy=19, nfit=62
trace:font:GetTextExtentExPointW returning cx=355, cy=19, nFit=0
trace:font:SetTextJustification (hdc=0xaa60, breakExtra=0, breakCount=0)
trace:font:GetTextExtentPoint32W (0xaa60 L"." 1 0x34c1c4): returning 3457528 x 0
trace:font:GetTextExtentExPointW (0xaa60, L".", 0)
trace:font:GetTextExtentExPointW hdc=0xaa60, cx=3457528, cy=0
trace:font:WineEngGetTextExtentExPoint 0x2de6e90, L".", 1, 0, 0x34c1c4
trace:font:WineEngGetTextExtentExPoint return cx=4, cy=19, nfit=1
trace:font:GetTextExtentExPointW returning cx=4, cy=19, nFit=0
trace:font:GetTextExtentPoint32W (0xaa60 L" " 1 0x34c1c4): returning 3457528 x 0
trace:font:GetTextExtentExPointW (0xaa60, L" ", 0)
trace:font:GetTextExtentExPointW hdc=0xaa60, cx=3457528, cy=0
trace:font:WineEngGetTextExtentExPoint 0x2de6e90, L" ", 1, 0, 0x34c1c4
trace:font:WineEngGetTextExtentExPoint return cx=4, cy=19, nfit=1
trace:font:GetTextExtentExPointW returning cx=4, cy=19, nFit=0
trace:font:GetTextExtentPoint32W (0xaa60 L" " 1 0x34c184): returning 3457464 x 0
trace:font:GetTextExtentExPointW (0xaa60, L" ", 0)
trace:font:GetTextExtentExPointW hdc=0xaa60, cx=3457464, cy=0
trace:font:WineEngGetTextExtentExPoint 0x2de6e90, L" ", 1, 0, 0x34c184
trace:font:WineEngGetTextExtentExPoint return cx=4, cy=19, nfit=1
trace:font:GetTextExtentExPointW returning cx=4, cy=19, nFit=0
---- LOG SECTION ENDS HERE ----

Btw, that last period was *not* painted.

I'm having some ideas here, but they don't seem very nice right now...
what about you? Keith?

TIA,
- Pedro.

Test case for Bug 50 [Was: Bug 50]

[Pedro Araujo Chaves Jr.]

I've just finished writing a test case for Bug 50, but I'm missing *a
single thing* that prevents it from working under Windows: I still
don't know how to get the width of the text output by ExtTextOutW().

MSDN isn't helping much, and I haven't found the optimal Google query yet... ;-)

Would anybody out there have a clue? I'm ready to submit patch and
test, but without that info, I can't...

Thanks in advance!
- Pedro.

Test case for Bug 50 [Was: Bug 50]

[Duane Clark]

Pedro Araujo Chaves Jr. wrote:
> I've just finished writing a test case for Bug 50, but I'm missing *a
> single thing* that prevents it from working under Windows: I still
> don't know how to get the width of the text output by ExtTextOutW().

GetTextExtentPoint32

For some examples in Wine, look at almost any control in comctl32.