Re: [PATCH 7/9] d3d11: Implement ID3D11UnorderedAccessView interface.
On 24 June 2016 at 11:46, Józef Kucia <jkucia(a)codeweavers.com> wrote:
+ switch (desc->ViewDimension) + { + case D3D11_UAV_DIMENSION_TEXTURE1DARRAY: + if (desc->u.Texture1DArray.ArraySize == -1 && desc->u.Texture1DArray.FirstArraySlice < layer_count) I noticed too late for the other normalisation functions, but "ArraySize" is unsigned.
On Fri, Jun 24, 2016 at 12:56 PM, Henri Verbeet <hverbeet(a)gmail.com> wrote:
On 24 June 2016 at 11:46, Józef Kucia <jkucia(a)codeweavers.com> wrote:
+ switch (desc->ViewDimension) + { + case D3D11_UAV_DIMENSION_TEXTURE1DARRAY: + if (desc->u.Texture1DArray.ArraySize == -1 && desc->u.Texture1DArray.FirstArraySlice < layer_count) I noticed too late for the other normalisation functions, but "ArraySize" is unsigned.
Should I use 0xffffffff in tests as well?
On 24 June 2016 at 13:23, Józef Kucia <joseph.kucia(a)gmail.com> wrote:
On Fri, Jun 24, 2016 at 12:56 PM, Henri Verbeet <hverbeet(a)gmail.com> wrote:
On 24 June 2016 at 11:46, Józef Kucia <jkucia(a)codeweavers.com> wrote:
+ switch (desc->ViewDimension) + { + case D3D11_UAV_DIMENSION_TEXTURE1DARRAY: + if (desc->u.Texture1DArray.ArraySize == -1 && desc->u.Texture1DArray.FirstArraySlice < layer_count) I noticed too late for the other normalisation functions, but "ArraySize" is unsigned.
Should I use 0xffffffff in tests as well?
I'd say ~0u.
participants (2)
-
Henri Verbeet -
Józef Kucia